feat: add overlayRole property to customize dialog role #7582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
approved these changes
Jul 25, 2024
vursen
reviewed
Jul 25, 2024
| @@ -64,6 +64,12 @@ describe('vaadin-dialog', () => { | |||
| expect(overlay.getAttribute('role')).to.be.eql('dialog'); | |||
| }); | |||
|
|
|||
| it('should change role attribute on the overlay based on overlayRole', async () => { | |||
There was a problem hiding this comment.
nit: Could it be a snapshot test?
There was a problem hiding this comment.
Good point, thanks. Moved this test and removed two others for default role and theme as they are also covered by existing snapshot tests.
There was a problem hiding this comment.
Extracted changes to unrelated tests to #7586 so that this PR doesn't touch unit tests.
|
|
This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #4977
Added
overlayRoleproperty similar to the one we now have invaadin-popoverto customize the dialog role.Type of change