Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 view shows Flow and Hilla views in different ways #19182

Closed
Legioth opened this issue Apr 17, 2024 · 1 comment · Fixed by #19742
Closed

404 view shows Flow and Hilla views in different ways #19182

Legioth opened this issue Apr 17, 2024 · 1 comment · Fixed by #19742
Labels
bug Released with Vaadin 24.4.9

Comments

@Legioth
Copy link
Member

Legioth commented Apr 17, 2024

Description of the bug

The default 404 view that list all available routes in development mode uses different formatting for Flow and Hilla views. Hilla views are shown with a leading / whereas Flow views are shown without a leading /.

Screenshot 2024-04-17 at 10 52 00

Expected behavior

Flow and Hilla views should be shown in the same way

Minimal reproducible example

  1. Get a Vaadin 24.4.0.alpha21 project with one Flow view and one Hilla view from start.vaadin.com
  2. mvn
  3. Open a URL for which no view exists, e.g. http://localhost:8080/foo

Versions

  • Vaadin / Flow version: Vaadin 24.4.0.alpha21
@mshabarov mshabarov added the bug label Apr 17, 2024
@mshabarov mshabarov moved this to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Apr 17, 2024
@mshabarov mshabarov moved this to 🔖 Normal Priority (P2) in Vaadin Flow bugs & maintenance (Vaadin 10+) Apr 17, 2024
caalador added a commit that referenced this issue Aug 5, 2024
@caalador
fix: Unify client route to match server route format
d53a43b 
Make the client route string
on the error page in dev mode
not start with / so it is the
same as for server-side routes.

Fixes #19182
@caalador caalador mentioned this issue Aug 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Normal Priority (P2) to ✅ Closed in Vaadin Flow bugs & maintenance (Vaadin 10+) Aug 5, 2024
@github-project-automation github-project-automation bot moved this from 🪵Product backlog to Done in Vaadin Flow ongoing work (Vaadin 10+) Aug 5, 2024
vaadin-bot pushed a commit that referenced this issue Aug 5, 2024
@caalador @vaadin-bot
fix: Unify client route to match server route format (#19742)
6dadae1 
Make the client route string
on the error page in dev mode
not start with / so it is the
same as for server-side routes.

Fixes #19182
vaadin-bot added a commit that referenced this issue Aug 6, 2024
@vaadin-bot @caalador
fix: Unify client route to match server route format (#19742) (CP: 24…
01053c3 
….4) (#19744)

* fix: Unify client route to match server route format (#19742)

Make the client route string
on the error page in dev mode
not start with / so it is the
same as for server-side routes.

Fixes #19182

* fix test expectation

---------

Co-authored-by: caalador <[email protected]>
Co-authored-by: Mikael Grankvist <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Released with Vaadin 24.4.9
Projects
Vaadin Flow bugs & maintenance (Vaadin 10+)
Status: ✅ Closed
Vaadin Flow ongoing work (Vaadin 10+)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Unify client route to match server route format vaadin/flow
3 participants
@Legioth @vaadin-bot @mshabarov