fix: Unify client route to match server route format #19742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the client route string on the error page in dev mode not start with / so it is the same as for server-side routes. Fixes #19182
|
mcollovati
approved these changes
Aug 5, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
Make the client route string on the error page in dev mode not start with / so it is the same as for server-side routes. Fixes #19182
vaadin-bot
added a commit
that referenced
this pull request
Aug 6, 2024
….4) (#19744) * fix: Unify client route to match server route format (#19742) Make the client route string on the error page in dev mode not start with / so it is the same as for server-side routes. Fixes #19182 * fix test expectation --------- Co-authored-by: caalador <[email protected]> Co-authored-by: Mikael Grankvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the client route string
on the error page in dev mode
not start with / so it is the
same as for server-side routes.
Fixes #19182