refactor!: extract shared combo-box overlay logic to mixin #5393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/combo-box-overlay-mixin
branch
2 times, most recently
from
de7c7fe
to
adcddfb
Compare
vursen
reviewed
Jan 25, 2023
This was referenced Jan 25, 2023
sissbruecker
approved these changes
Jan 26, 2023
web-padawan
force-pushed
the
refactor/combo-box-overlay-mixin
branch
from
93f5c4b
to
4019a93
Compare
vursen
approved these changes
Jan 26, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #5358
Same as #5391 but for the following components:
vaadin-combo-box-overlayvaadin-time-picker-overlayvaadin-multi-select-combo-box-overlayThis PR decouples
TimePickerOverlayandMultiSelectComboBoxOverlayby making them use shared mixin.Also, theme files have been updated to export
csstagged literals that are used by all of these components.Type of change