docs: update JSDoc and typings, mark some methods as private #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
changed the title
web-padawan
commented
Jan 25, 2023
|
I guess this could be also moved to the bottom of the file: web-components/packages/overlay/src/vaadin-overlay.js Lines 469 to 470 in 2d32545 |
vursen
reviewed
Jan 25, 2023
web-padawan
force-pushed
the
docs/overlay-methods
branch
2 times, most recently
from
3f5190b
to
ff8d698
Compare
web-padawan
force-pushed
the
docs/overlay-methods
branch
from
e3be775
to
8dad1d6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Jan 26, 2023
|
This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #5393 (comment)
Type of change