Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: fix xinfogroups; fix lrem #2324

Merged

Conversation

acarbonetto
Copy link
Collaborator

@acarbonetto acarbonetto commented Sep 18, 2024

Add support for:

  • The xinfoGroups key argument should take binary keys.
  • lrem for transactions members argument should take binary keys.

Fixes: #2325

Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto requested a review from a team as a code owner September 18, 2024 23:16
Signed-off-by: Andrew Carbonetto <[email protected]>
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@acarbonetto acarbonetto merged commit ae86153 into valkey-io:release-1.1 Sep 19, 2024
9 checks passed
@acarbonetto acarbonetto deleted the node/acarbo_fix_xinfogroups branch September 19, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants