Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): rollout completely rewritten bs-dropdown version #1771

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Mar 16, 2017

@SergeyKuryatnick
Copy link
Contributor

SergeyKuryatnick commented Mar 21, 2017

Fixed:
#1674
#1749
#1623
#1415
#802
#569
#530
#6
#1540
#1217
#591
#478

Not fixed:
#1596 - multi-dropdown is unavailable for now

@valorkin valorkin force-pushed the bs-dropdown-v2 branch 3 times, most recently from ab3664e to eea1946 Compare March 24, 2017 15:46
@valorkin
Copy link
Member Author

fixes #1674, fixes #1749, fixes #1623, fixes #1415, fixes #802, fixes #569, fixes #530, fixes #6,
fixes #1540, fixes #1217, fixes #591, fixes #478

feat: you can pass dropdown configuration in forRoot() method
feat: now you can add dropdown to body by using container="body"

BREAKING CHANGES:

  • DropdownModule renamed to BsDropdownModule, same to all dropdown components added bs prefix
  • addToggleClass option is deprecated, now you need to add dropdown-toggle class manually if needed
  • dropdownMenu menu become a template selector, so * should be added
    sample: <ul dropdownMenu> should become <ul *dropdownMenu>
  • onToggle event deprecated use isOpenChange instead
  • appendToBody deprecated, use container="body" instead, now dropdown behaviour and attachment params alligned with tooltips and popovers
  • keyboardNav deprecated
  • disabled renamed to isDisabled
  • dropdownToggle doesn't prevent default behaviour anymore

fixes #1674, fixes #1749, fixes #1623, fixes #1415, fixes #802, fixes #569, fixes #530, fixes #6,
fixes #1540, fixes #1217, fixes #591, fixes #478
@codecov-io
Copy link

codecov-io commented Mar 24, 2017

Codecov Report

❗ No coverage uploaded for pull request base (development@3264308). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1771   +/-   ##
==============================================
  Coverage               ?   85.95%           
==============================================
  Files                  ?       78           
  Lines                  ?     2101           
  Branches               ?      273           
==============================================
  Hits                   ?     1806           
  Misses                 ?      202           
  Partials               ?       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3264308...b15a828. Read the comment docs.

@valorkin valorkin merged commit 31cba41 into development Mar 24, 2017
@valorkin valorkin deleted the bs-dropdown-v2 branch March 24, 2017 16:59
@touqeershafi
Copy link

is this available in master?

@valorkin
Copy link
Member Author

you mean in npm?

@touqeershafi
Copy link

touqeershafi commented Mar 27, 2017

Yeah, how can i use this using npm.

I've tried using npm install ng2-bootstrap@beta --save but the changes is not effecting.

@linusbrolin
Copy link
Contributor

@valorkin why is keyboardNav deprecated?
I can't find any information why this was done...
So keyboard navigation in the dropdown will no longer work after this update?

@valorkin
Copy link
Member Author

You use keyboard nav? I will get it back later

@linusbrolin
Copy link
Contributor

Ok, good to know.
Yeah, I use keyboard navigation from time to time.

@valorkin
Copy link
Member Author

My next prio is finish new datepicker, which is implemented half of a year ago... shame on me

@valorkin
Copy link
Member Author

And then Typeahead, where I will need a keyboard navigation... bit this time it will be much smarter

@umagon
Copy link

umagon commented Mar 28, 2017

I, too, am unable to update ng2-bootstrap. My current version is 1.4.2.

@rzubov-devpro
Copy link

rzubov-devpro commented Mar 29, 2017

@valorkin Looks like you have to bump package version to make it possible to get changes via npm usual way. Till that we have to use "ng2-bootstrap": "*" in package.json

@valorkin
Copy link
Member Author

Bumped :)

@RakeshMaddala
Copy link

@valorkin - Can you please provide me some information related to keyboardNav ? Is it available now? if not, then is it planned for release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants