-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dropdown): rollout completely rewritten bs-dropdown version #1771
Conversation
ab3664e
to
eea1946
Compare
fixes #1674, fixes #1749, fixes #1623, fixes #1415, fixes #802, fixes #569, fixes #530, fixes #6, feat: you can pass dropdown configuration in BREAKING CHANGES:
|
eea1946
to
b15a828
Compare
Codecov Report
@@ Coverage Diff @@
## development #1771 +/- ##
==============================================
Coverage ? 85.95%
==============================================
Files ? 78
Lines ? 2101
Branches ? 273
==============================================
Hits ? 1806
Misses ? 202
Partials ? 93 Continue to review full report at Codecov.
|
is this available in master? |
you mean in npm? |
Yeah, how can i use this using npm. I've tried using |
@valorkin why is keyboardNav deprecated? |
You use keyboard nav? I will get it back later |
Ok, good to know. |
My next prio is finish new datepicker, which is implemented half of a year ago... shame on me |
And then Typeahead, where I will need a keyboard navigation... bit this time it will be much smarter |
I, too, am unable to update ng2-bootstrap. My current version is 1.4.2. |
@valorkin Looks like you have to bump package version to make it possible to get changes via npm usual way. Till that we have to use "ng2-bootstrap": "*" in package.json |
Bumped :) |
@valorkin - Can you please provide me some information related to keyboardNav ? Is it available now? if not, then is it planned for release ? |
should fix all these issues:
https://github.com/valor-software/ng2-bootstrap/labels/comp%28dropdown%29