Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): make dropdown-toggle class optional #1540

Closed
sumpton opened this issue Jan 23, 2017 · 2 comments
Closed

feat(dropdown): make dropdown-toggle class optional #1540

sumpton opened this issue Jan 23, 2017 · 2 comments

Comments

@sumpton
Copy link

sumpton commented Jan 23, 2017

update by @valorkin:

should be added option to config, to disable adding of dropdown toggle class


Thank you for all your work. We appreciate it.

We have been using Bootstrap 4 for months, but I just was switching our dropdown menus to the ng2-bootstrap dropdown.

It would be great if the component did not add the dropdown-toggle class so that it would remain optional as it is with Bootstrap. I am now need to use an additional class to override.

Thanks again!

@valorkin
Copy link
Member

@sumpton my bad, I didn't knew that it is optional
dropdown is under a small refactoring to allow append to body
after it I think this should be added

@valorkin valorkin changed the title dropdown -- omit adding class dropdown-toggle feat(dropdown): make dropdown-toggle class optional Jan 23, 2017
@sumpton
Copy link
Author

sumpton commented Jan 23, 2017

That would be terrific.

A design goal might be to have the Angular bit as light as is possible; working with markup that is as close to Bootstraps as is possible, preferably identical. As I understand it, all that needs to change is the "show" class flag -- maybe animation; I don't know how that works. Ideally, most of the time, Bootstrap should be able to change their CSS and markup and not break Angular.

valorkin added a commit that referenced this issue Mar 24, 2017
fixes #1674, fixes #1749, fixes #1623, fixes #1415, fixes #802, fixes #569, fixes #530, fixes #6,
fixes #1540, fixes #1217, fixes #591, fixes #478
valorkin added a commit that referenced this issue Mar 24, 2017
fixes #1674, fixes #1749, fixes #1623, fixes #1415, fixes #802, fixes #569, fixes #530, fixes #6,
fixes #1540, fixes #1217, fixes #591, fixes #478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants