Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.json #2

Closed
wants to merge 8 commits into from

Conversation

grundoon
Copy link
Member

Updates manifest.json current as of 2018-10-25 to reflect latest versions of currently listed repos.

This is a highly imperfect update (more a bit of a stopgap until vapor/vapor#1827 potential solutions can really be addressed), that takes liberties to:

(a) add all currentmajor.minor versions, at latest .patch point
(b) adds a previousmajor version, at latest .minor.patch point, in a few repos where structure hasn't significantly changed (surely a separation of vapor 2 and vapor 3 documentation entirely, or a thorough reworking by somebody way more familiar with all these major structural changes, would be far superior)
(c) removes a few seemingly pointless entries (e.g. RC versions, minor versions at outdated .patch levels)

Updates manifest.json current as of 2018-10-25 to reflect latest versions of currently listed repos.

This is highly imperfect update (more a bit of a stopgap until vapor/vapor#1827 potential solutions can really be addressed), that takes liberties to:

 (a) add all `currentmajor.minor` versions, at latest `.patch` point
 (b) adds a `previousmajor` version, at latest `.minor.patch` point, in a few repos where structure hasn't significantly changed (surely a separation of vapor 2 and vapor 3 documentation entirely, or a thorough reworking by somebody way more familiar with all these major structural changes, would be far superior)
 (c) removes a few seemingly pointless entries (e.g. RC versions, minor versions at outdated `.patch` levels)
@tanner0101
Copy link
Member

tanner0101 commented Oct 31, 2018

The manifest.json file is generated automatically when deploy.sh is run.

I think what you mean to do here is create a separate file that stores all versions that should be generated. Basically a separate file that could be parsed and used to call generate.sh for each version required.

The syntax for generating is:

./generate.sh vapor Vapor 3.1.3

@grundoon
Copy link
Member Author

Wow, I must've been really tired when I did this – not only failed to read through the entire flow, but mis-read the parts I did read. 🙄

Just trying to make sure things were up-to-date for when/if the docs did get regen'ed. Oops.

@tanner0101
Copy link
Member

tanner0101 commented Oct 31, 2018

Yeah, currently the workflow is very manual. I run something like:

./generate.sh vapor Vapor 3.1.3

I run that one or more times for all of the new tags. Then:

./deploy

Which generates the manifest and pushes.

It would be nicer if I could add the new tag to some meta-manifest, and then just run ./deploy which would generate and push. That would get us one step closer to being able to generate fresh with each deploy

@tanner0101 tanner0101 closed this Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants