Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API docs #1827

Closed
grundoon opened this issue Oct 6, 2018 · 9 comments
Closed

Update API docs #1827

grundoon opened this issue Oct 6, 2018 · 9 comments
Labels
enhancement New feature or request

Comments

@grundoon
Copy link
Member

grundoon commented Oct 6, 2018

Looks like the API documentation has not been regenerated since 3.0.2, as the maxBodySize value typo is still present here:

https://api.vapor.codes/vapor/latest/Vapor/Structs/NIOServerConfig.html#/s:5Vapor15NIOServerConfigV7defaultACSS8hostname_Si4portSi7backlogSi11workerCountSi11maxBodySizeSb12reuseAddressSb10tcpNoDelaytFZ

@jdmcd
Copy link
Member

jdmcd commented Oct 6, 2018

On a side note, I’d love to try and find a way to hook this into the CI process or something. The more things like this we can automate the easier life will be.

@grundoon
Copy link
Member Author

grundoon commented Oct 6, 2018

Now that I've taken the time to look at a few more repos, it looks to be universal: latest is not actually latest release in any of the ones I checked (the links to GitHub source are all to prior release blobs, though at least usually latest minors).

So yeah, what @mcdappdev says, in spades.

@0xTim
Copy link
Member

0xTim commented Oct 13, 2018

+1 to automatic deployments from CI on every commit on master

@tanner0101
Copy link
Member

tanner0101 commented Oct 17, 2018

Currently the API docs are generated locally, then the compiled HTML is pushed to the deploy server. I'd love to update it so that the HTML is generated during the deployment, but I'm not sure it's possible since the generation relies on SourceKitten and Jazzy. I know SourceKitten has been ported to Linux, but I'm not sure if it has all of the required features.

Basically, I (or any volunteers) need to spend a couple of hours trying to get the generation script running on Linux. If it indeed works, then we just need to conjure up a Dockerfile that can pull the necessary repos and compile the docs during deployment. We could even get fancy and use GitHub APIs to automatically compile docs for the latest n releases.

@jdmcd
Copy link
Member

jdmcd commented Oct 17, 2018

Ah, I didn't realize it relied on SourceKitten. But yeah if there's a way to get it to run on Linux it should be fairly trivial to implement the rest. Would be super cool to use the new Github stuff for it.

@0xTim
Copy link
Member

0xTim commented Oct 17, 2018 via email

@joscdk
Copy link
Member

joscdk commented Oct 17, 2018

Looks like some work are being done to get Jazzy to work on Linux realm/jazzy#495

After that, with the new API and custom docker, it should be fairly simple to get up on Cloud 2 with something automated :)

@calebkleveter
Copy link
Member

It looks like you can use Jazzy on Linux since the packages are built with SPM: realm/jazzy#487 (comment)

grundoon added a commit to grundoon/api-documentation that referenced this issue Oct 25, 2018
Updates manifest.json current as of 2018-10-25 to reflect latest versions of currently listed repos.

This is highly imperfect update (more a bit of a stopgap until vapor/vapor#1827 potential solutions can really be addressed), that takes liberties to:

 (a) add all `currentmajor.minor` versions, at latest `.patch` point
 (b) adds a `previousmajor` version, at latest `.minor.patch` point, in a few repos where structure hasn't significantly changed (surely a separation of vapor 2 and vapor 3 documentation entirely, or a thorough reworking by somebody way more familiar with all these major structural changes, would be far superior)
 (c) removes a few seemingly pointless entries (e.g. RC versions, minor versions at outdated `.patch` levels)
@tanner0101 tanner0101 added the enhancement New feature or request label Apr 1, 2020
@tanner0101 tanner0101 changed the title API docs need occasional regeneration :) Update API docs Apr 1, 2020
@Joannis
Copy link
Member

Joannis commented Aug 27, 2020

Closing this, because the docs are automatically regenerated nowadays.

@Joannis Joannis closed this as completed Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants