docs: Add empty as a explicit condition kwarg
#3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already being handled internally, but now aligns with `when` and provides a documentable parameter. Related: vega#3485 (comment)
An IDE will still be able to trigger this the same way, but when scrolling through (up/down arrows) this has now has lower precedence
It is already covered by `**kwargs`, and this overload describes when an exception is raised https://typing.readthedocs.io/en/latest/spec/special-types.html#never
|
Thanks! |
9 tasks
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix:
This was already being handled internally, but now aligns more closely with
whenand provides a documentable argument.I was hoping to get this doc approved, before moving onto
when-then-otherwiseas this is a smaller change - but will be reused there multiple times