Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add empty as a explicit condition kwarg #3490

Merged
merged 7 commits into from
Jul 21, 2024
Merged

docs: Add empty as a explicit condition kwarg #3490

merged 7 commits into from
Jul 21, 2024

Commits on Jul 21, 2024

  1. refactor: add empty as an explicit condition kwarg 

    This was already being handled internally, but now aligns with `when` and provides a documentable parameter.
Related: vega#3485 (comment)
    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    09c355d View commit details
    Browse the repository at this point in the history

  2. feat(typing): include empty in condition overloads

    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    f994382 View commit details
    Browse the repository at this point in the history

  3. docs: copy empty doc from when

    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    6653b70 View commit details
    Browse the repository at this point in the history

  4. docs: add note on per-condition empty control

    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    2bd7b6f View commit details
    Browse the repository at this point in the history

  5. refactor(typing): reorder Never overload to occur last 

    An IDE will still be able to trigger this the same way, but when scrolling through (up/down arrows) this has now has lower precedence
    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    127f2b2 View commit details
    Browse the repository at this point in the history

  6. refactor(typing): remove empty from Never overload 

    It is already covered by `**kwargs`, and this overload describes when an exception is raised https://typing.readthedocs.io/en/latest/spec/special-types.html#never
    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    f52d3bc View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into condition-param-empty

    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    20cbc8f View commit details
    Browse the repository at this point in the history