Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lat/Long shouldn't support ValueDef #6154

Closed
kanitw opened this issue Mar 25, 2020 · 4 comments · Fixed by #6993
Closed

Lat/Long shouldn't support ValueDef #6154

kanitw opened this issue Mar 25, 2020 · 4 comments · Fixed by #6993
Assignees
@kanitw
Labels
Bug 🐛 P3 Should be fixed at some point
Milestone
5.0

Comments

@kanitw
Copy link
Member

kanitw commented Mar 25, 2020

(only datumdef make sense and it's now supported in #6150)
@kanitw kanitw added this to the 5.0 milestone Mar 25, 2020
@kanitw kanitw mentioned this issue Mar 25, 2020
Merged
17 tasks
@domoritz
Copy link
Member

Why Vega-Lite 5? Is this a breaking change?

@kanitw
Copy link
Member Author

kanitw commented Mar 25, 2020

It removes a feature that's previously working, though we could argue that this is a bug. No rush to do it though.

@domoritz
Copy link
Member

I'm okay with doing it pre 5 since it's a bug right now.

@kanitw kanitw added the P3 Should be fixed at some point label Mar 26, 2020
@kanitw kanitw self-assigned this Oct 9, 2020
kanitw added a commit that referenced this issue Oct 25, 2020
@kanitw
fix!: latitude/longitude should not support valueDef
6f0c7a2 
fix #6154
@kanitw kanitw mentioned this issue Oct 25, 2020
Merged
@kanitw
Copy link
Member Author

kanitw commented Oct 25, 2020

Will be fixed in #6993

@kanitw kanitw closed this as completed Oct 25, 2020
kanitw added a commit that referenced this issue Oct 25, 2020
@kanitw
fix!: latitude/longitude should not support valueDef (#6993)
b7827ce 
fix #6154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanitw kanitw

Labels
Bug 🐛 P3 Should be fixed at some point
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

fix!: latitude/longitude should not support valueDef vega/vega-lite
2 participants
@kanitw @domoritz