-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support datum in encoding #6150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kanitw
force-pushed
the
kw/datum
branch
4 times, most recently
from
March 25, 2020 15:05
9cb3ae7
to
ce3a5ac
Compare
This was referenced Mar 25, 2020
kanitw
force-pushed
the
kw/datum
branch
4 times, most recently
from
March 25, 2020 16:55
86a0374
to
2eff95e
Compare
This was referenced Mar 25, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I also just found the code to patch :-P |
It's actually more than an optimization if we use opacity for the rule. |
Actually, the right spec is {
"$schema": "https://vega.github.io/schema/vega-lite/v4.json",
"layer": [
{
"data": {
"values": [
{"a": "A", "b": 28},
{"a": "B", "b": 55},
{"a": "C", "b": 43},
{"a": "D", "b": 91},
{"a": "E", "b": -81},
{"a": "F", "b": 53},
{"a": "G", "b": -19},
{"a": "H", "b": 87},
{"a": "I", "b": 52}
]
},
"mark": "line",
"encoding": {
"x": {"field": "a", "type": "ordinal"},
"y": {"field": "b", "type": "quantitative"}
}
},
{"data": {"values": [{}]}, "mark": "rule", "encoding": {"y": {"datum": 0}}}
]
} |
domoritz
reviewed
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4201
Fix #1601
Merge #6149 first!
TODO
isFieldDef
getFieldDef
model.fieldDef
hasConditionalFieldDef
channelHasField
forEachFieldDef
reduceFieldDef
support datum for lat/long
repeat in datum
Examples
Later