Start datum encoding. #4201
Closed
Start datum encoding. #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
reviewed
Oct 19, 2018
| /** | ||
| * A constant value in data domain. | ||
| */ | ||
| datum: DatumValue; |
There was a problem hiding this comment.
Don't you have to support scale (and possibly guide)?
|
https://stackoverflow.com/questions/55015304/how-do-i-add-a-layer-in-a-shape-of-a-box-to-an-altair-plot suggests that having |
|
Once this is done, it's worth modifying the example in #5012 too. |
This was referenced Jun 9, 2019
kanitw
reviewed
Jun 12, 2019
| @@ -30,23 +30,37 @@ import {AggregatedFieldDef, WindowFieldDef} from './transform'; | |||
| import {getFullName, QUANTITATIVE, Type} from './type'; | |||
| import {contains, flatAccessWithDatum, getFirstDefined, replacePathInField, titlecase} from './util'; | |||
|
|
|||
| type Value = number | string | boolean | null; | |||
| type VisualValue = number | string; | |||
There was a problem hiding this comment.
-
value can be null too, why are you removing it?
-
Better not rename and keep it
Value
domoritz
force-pushed
the
master
branch
11 times, most recently
from
e31b0d5
to
35b6aed
Compare
17 tasks
|
will be replaced by #6150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1601
Starting point for someone to pick up.