Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For ImageKit.io in Image Component #18408

Closed
dukesx opened this issue Oct 28, 2020 · 5 comments
Closed

Add Support For ImageKit.io in Image Component #18408

dukesx opened this issue Oct 28, 2020 · 5 comments
Labels
good first issue Easy to fix issues, good for newcomers
Milestone

Comments

@dukesx
Copy link

dukesx commented Oct 28, 2020

Feature request

Is your feature request related to a problem? Please describe.

Yes, the problem is the missing support for ImageKit.io as an image optimization provider. I am currently using it, its free, generous and excellent . Now, the image component supports all major options except this one.

it should be noted however, that ImageKit is also a well known provider and competitor to Cloudinary.

Describe the solution you'd like

Just add the support for it just like Cloudinary. Fairly similar in query string but a few changes in it.

Describe alternatives you've considered

Ant-Design's Image Component, React Progressive Graceful Image

Additional context

None

@Timer Timer added good first issue Easy to fix issues, good for newcomers kind: story labels Nov 1, 2020
@Timer Timer modified the milestone: backlog Nov 1, 2020
@nikniv
Copy link

nikniv commented Nov 4, 2020

Hi there! I am working on this and will add a PR soon.

@dukesx
Copy link
Author

dukesx commented Nov 4, 2020

Hi there! I am working on this and will add a PR soon.

@nikniv Awesome!! Thank you so much ☺️

@nikniv
Copy link

nikniv commented Nov 10, 2020

@Timer It would be wonderful if you or someone else could please review PR #18878. In case any changes are needed before it can be released, I would be happy to do them promptly.

@Timer
Copy link
Member

Timer commented Jan 5, 2021

Hi! We just added the ability to pass your own custom loader to the Image component, so we're no longer accepting new built-in providers.

See this PR to learn how to use it: #20788

Thanks!

@Timer Timer closed this as completed Jan 5, 2021
@Timer Timer added this to the iteration 15 milestone Jan 5, 2021
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants