Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for custom image loaders. #20788

Merged
merged 7 commits into from
Jan 6, 2021
Merged

Add docs for custom image loaders. #20788

merged 7 commits into from
Jan 6, 2021

Conversation

leerob
Copy link
Member

@leerob leerob commented Jan 5, 2021

Docs for #20216.

@ijjk
Copy link
Member

ijjk commented Jan 5, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary leerob/next.js custom-loader-docs Change
buildDuration 8.9s 8.9s ⚠️ +36ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary leerob/next.js custom-loader-docs Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.788 1.801 ⚠️ +0.01
/ avg req/sec 1398.44 1388.12 ⚠️ -10.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.144 1.114 -0.03
/error-in-render avg req/sec 2185.49 2243.63 +58.14
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js custom-loader-docs Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js custom-loader-docs Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary leerob/next.js custom-loader-docs Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js custom-loader-docs Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js custom-loader-docs Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary leerob/next.js custom-loader-docs Change
buildDuration 10.5s 10.3s -166ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js custom-loader-docs Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js custom-loader-docs Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary leerob/next.js custom-loader-docs Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js custom-loader-docs Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary leerob/next.js custom-loader-docs Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: db79cec

@ijjk
Copy link
Member

ijjk commented Jan 5, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary leerob/next.js custom-loader-docs Change
buildDuration 11.1s 11.6s ⚠️ +434ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary leerob/next.js custom-loader-docs Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.228 2.164 -0.06
/ avg req/sec 1122.14 1155.4 +33.26
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.432 1.443 ⚠️ +0.01
/error-in-render avg req/sec 1745.9 1733 ⚠️ -12.9
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js custom-loader-docs Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js custom-loader-docs Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary leerob/next.js custom-loader-docs Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js custom-loader-docs Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js custom-loader-docs Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary leerob/next.js custom-loader-docs Change
buildDuration 13.8s 13.3s -438ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js custom-loader-docs Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js custom-loader-docs Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary leerob/next.js custom-loader-docs Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js custom-loader-docs Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary leerob/next.js custom-loader-docs Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: f389481

@Timer Timer added this to the iteration 15 milestone Jan 5, 2021
This was referenced Jan 5, 2021
Closed
Closed
Closed
Closed
Closed
Closed
@ijjk
Copy link
Member

ijjk commented Jan 5, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary leerob/next.js custom-loader-docs Change
buildDuration 9.8s 9.7s -55ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary leerob/next.js custom-loader-docs Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.953 1.934 -0.02
/ avg req/sec 1280.21 1292.57 +12.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.235 1.212 -0.02
/error-in-render avg req/sec 2024.23 2062.73 +38.5
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js custom-loader-docs Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js custom-loader-docs Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary leerob/next.js custom-loader-docs Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js custom-loader-docs Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js custom-loader-docs Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary leerob/next.js custom-loader-docs Change
buildDuration 11.8s 11.9s ⚠️ +56ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js custom-loader-docs Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js custom-loader-docs Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary leerob/next.js custom-loader-docs Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js custom-loader-docs Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary leerob/next.js custom-loader-docs Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 86033bb

@Timer Timer marked this pull request as ready for review January 6, 2021 01:54
@ijjk
Copy link
Member

ijjk commented Jan 6, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary leerob/next.js custom-loader-docs Change
buildDuration 8.8s 9s ⚠️ +244ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary leerob/next.js custom-loader-docs Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.684 1.764 ⚠️ +0.08
/ avg req/sec 1484.36 1417.58 ⚠️ -66.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.102 1.11 ⚠️ +0.01
/error-in-render avg req/sec 2267.98 2251.97 ⚠️ -16.01
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js custom-loader-docs Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f258db..b7d8.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js custom-loader-docs Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary leerob/next.js custom-loader-docs Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js custom-loader-docs Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js custom-loader-docs Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary leerob/next.js custom-loader-docs Change
buildDuration 10.5s 10.5s -48ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js custom-loader-docs Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1f258db..b7d8.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js custom-loader-docs Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary leerob/next.js custom-loader-docs Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js custom-loader-docs Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary leerob/next.js custom-loader-docs Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: a4069fd

@kodiakhq kodiakhq bot merged commit 9afc0f5 into vercel:canary Jan 6, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@styfle styfle styfle approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
iteration 15
Development

Successfully merging this pull request may close these issues.
4 participants
@leerob @ijjk @styfle @Timer