Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port next-page-disallow-re-export-all-exports plugin to next-swc #30810

Closed
timneutkens opened this issue Nov 2, 2021 · 1 comment · Fixed by #31582
Closed

Port next-page-disallow-re-export-all-exports plugin to next-swc #30810

timneutkens opened this issue Nov 2, 2021 · 1 comment · Fixed by #31582
Labels
SWC Related to minification/transpilation in Next.js.

Comments

@timneutkens
Copy link
Member

timneutkens commented Nov 2, 2021 •
edited
Loading

This transform disallows re-exporting *. It wasn't ported to next-swc yet as we prioritized other transforms but would be good to add this back as it prevents a pitfall where getStaticProps/getServerSideProps can't be tree-shaken from the page.
@timneutkens timneutkens added kind: story SWC Related to minification/transpilation in Next.js. labels Nov 2, 2021
@hanneslund hanneslund mentioned this issue Nov 18, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #31582 Nov 19, 2021
kodiakhq bot pushed a commit that referenced this issue Nov 19, 2021
@hanneslund
Implement SWC port of next-page-disallow-re-export-all-exports (#31582)
1d2ac3b 
Fixes #30810

Added tests similar to the fixture ones, but the output is stderr. That way the test can make sure the error message and span is correct. Let me know if you think this is a bad idea.
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
@hanneslund @natew
Implement SWC port of next-page-disallow-re-export-all-exports (verce…
743ab8b 
…l#31582)

Fixes vercel#30810

Added tests similar to the fixture ones, but the output is stderr. That way the test can make sure the error message and span is correct. Let me know if you think this is a bad idea.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
SWC Related to minification/transpilation in Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement SWC port of next-page-disallow-re-export-all-exports hanneslund/next.js
2 participants
@timneutkens @balazsorban44