Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SWC port of next-page-disallow-re-export-all-exports #31582

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

hanneslund
Copy link
Contributor

Fixes #30810

Added tests similar to the fixture ones, but the output is stderr. That way the test can make sure the error message and span is correct. Let me know if you think this is a bad idea.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 18, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
buildDuration 22.6s 22.4s -160ms
buildDurationCached 4.4s 4.4s -1ms
nodeModulesSize 339 MB 339 MB -6 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
/ failed reqs 0 0
/ total time (seconds) 4.007 4.113 ⚠️ +0.11
/ avg req/sec 623.9 607.87 ⚠️ -16.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.104 2.187 ⚠️ +0.08
/error-in-render avg req/sec 1187.94 1143.28 ⚠️ -44.66
Client Bundles (main, webpack, commons)
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
buildDuration 24.7s 25.7s ⚠️ +1s
buildDurationCached 4.3s 4.4s ⚠️ +115ms
nodeModulesSize 339 MB 339 MB -6 B
Page Load Tests Overall increase ✓
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
/ failed reqs 0 0
/ total time (seconds) 3.988 4.001 ⚠️ +0.01
/ avg req/sec 626.84 624.79 ⚠️ -2.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.198 2.194 0
/error-in-render avg req/sec 1137.27 1139.65 +2.38
Client Bundles (main, webpack, commons)
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js disallow-re-export-all-in-page Change
index.html gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: dd774d1

@kodiakhq kodiakhq bot merged commit 1d2ac3b into vercel:canary Nov 19, 2021
@hanneslund hanneslund deleted the disallow-re-export-all-in-page branch November 19, 2021 10:45
@hanneslund hanneslund restored the disallow-re-export-all-in-page branch November 19, 2021 10:45
@hanneslund hanneslund deleted the disallow-re-export-all-in-page branch November 19, 2021 10:46
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port next-page-disallow-re-export-all-exports plugin to next-swc
3 participants