Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing test for #33703 and #23824 #33765

Closed
wants to merge 1 commit into from
Closed

Add failing test for #33703 and #23824 #33765

wants to merge 1 commit into from

Conversation

timneutkens
Copy link
Member

Add tests for the cases described in #33703 and #23824 as well as a few more.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@timneutkens
Add failing test for vercel#33703 and vercel#23824
1a3bed1 
Add tests for the cases described in vercel#33703 and vercel#23824 as well as a few more.
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jan 28, 2022
@ijjk
Copy link
Member

ijjk commented Jan 28, 2022

Failing test suites

Commit: 1a3bed1

test/e2e/dynamic-route-interpolation/index.test.ts

  • Dynamic Route Interpolation > should work with parameter itself
  • Dynamic Route Interpolation > should work with parameter itself in API routes
  • Dynamic Route Interpolation > should work with brackets in API routes
Expand output

● Dynamic Route Interpolation › should work with parameter itself

expect(received).toBe(expected) // Object.is equality

Expected: "[slug]"
Received: ""

  44 |     const $ = cheerio.load(html)
  45 |     expect($('#slug').text()).toBe('[slug]')
> 46 |   })
     |     ^
  47 |
  48 |   it('should work with brackets', async () => {
  49 |     const html = await renderViaHTTP(next.url, '/blog/[abc]')

  at Object.<anonymous> (e2e/dynamic-route-interpolation/index.test.ts:46:35)

● Dynamic Route Interpolation › should work with parameter itself in API routes

expect(received).toBe(expected) // Object.is equality

Expected: "[slug]"
Received: ""

  54 |   it('should work with parameter itself in API routes', async () => {
  55 |     const html = await renderViaHTTP(next.url, '/api/dynamic/[slug]')
> 56 |     const $ = cheerio.load(html)
     |                                 ^
  57 |     expect($('#slug').text()).toBe('[slug]')
  58 |   })
  59 |

  at Object.<anonymous> (e2e/dynamic-route-interpolation/index.test.ts:56:35)

● Dynamic Route Interpolation › should work with brackets in API routes

expect(received).toBe(expected) // Object.is equality

Expected: "[abc]"
Received: ""

  59 |
  60 |   it('should work with brackets in API routes', async () => {
> 61 |     const html = await renderViaHTTP(next.url, '/api/dynamic/[abc]')
     |                                   ^
  62 |     const $ = cheerio.load(html)
  63 |     expect($('#slug').text()).toBe('[abc]')
  64 |   })

  at Object.<anonymous> (e2e/dynamic-route-interpolation/index.test.ts:61:35)

@ijjk
Copy link
Member

ijjk commented Jan 28, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
buildDuration 15.9s 15.6s -304ms
buildDurationCached 4s 4.1s ⚠️ +76ms
nodeModulesSize 358 MB 358 MB -12 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.894 3.835 -0.06
/ avg req/sec 641.94 651.85 +9.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.963 2.009 ⚠️ +0.05
/error-in-render avg req/sec 1273.71 1244.34 ⚠️ -29.37
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.94 kB 4.94 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.4 kB 14.4 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
index.html gzip 530 B 530 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
buildDuration 20.7s 20.5s -192ms
buildDurationCached 4.1s 3.9s -146ms
nodeModulesSize 358 MB 358 MB -12 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.975 3.937 -0.04
/ avg req/sec 629 635.04 +6.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.099 2.094 -0.01
/error-in-render avg req/sec 1190.96 1193.61 +2.65
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.97 kB 4.97 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.21 kB 2.21 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/dynamic-route-interpolation Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 1a3bed1

@jameshfisher jameshfisher mentioned this pull request Jan 30, 2022
Merged
3 tasks
@kodiakhq kodiakhq bot closed this in #33808 Feb 2, 2022
kodiakhq bot pushed a commit that referenced this pull request Feb 2, 2022
@jameshfisher @timneutkens @ijjk
Bug fix: dynamic page should not be interpreted as predefined page (#…
965d26e 
…33808)

Fixes: #17096
Fixes: #23824
Closes: #33765

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added in #33765
- [x] Errors have helpful link attached (N/A)

Co-authored-by: Tim Neutkens <[email protected]>
Co-authored-by: JJ Kasper <[email protected]>
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@jameshfisher @timneutkens
@ijjk @natew
Bug fix: dynamic page should not be interpreted as predefined page (v…
be1397a 
…ercel#33808)

Fixes: vercel#17096
Fixes: vercel#23824
Closes: vercel#33765

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added in vercel#33765
- [x] Errors have helpful link attached (N/A)

Co-authored-by: Tim Neutkens <[email protected]>
Co-authored-by: JJ Kasper <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @ijjk