Bug fix: dynamic page should not be interpreted as predefined page #33808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for the cases described in vercel#33703 and vercel#23824 as well as a few more.
jameshfisher
requested review from
huozhi,
ijjk,
shuding and
timneutkens
as code owners
This comment has been minimized.
This comment has been minimized.
…-used-as-page-path
ijjk
reviewed
Jan 31, 2022
…shfisher/next.js into url-should-not-be-used-as-page-path
|
@timneutkens it looks like the API tests are expecting HTML, but the API routes are returning plaintext? (Or am I misreading it) |
|
@jameshfisher right, I went ahead and updated those cases and looks good now |
Stats from current PRDefault Build (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| buildDuration | 14.6s | 14.4s | -192ms |
| buildDurationCached | 3.7s | 3.8s | |
| nodeModulesSize | 359 MB | 359 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 3.377 | 3.444 | |
| / avg req/sec | 740.25 | 725.8 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.498 | 1.536 | |
| /error-in-render avg req/sec | 1668.43 | 1627.61 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 27.2 kB | 27.2 kB | ✓ |
| webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
| Overall change | 71.1 kB | 71.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 326 B | 326 B | ✓ |
| dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 919 B | 919 B | ✓ |
| image-HASH.js gzip | 4.94 kB | 4.94 kB | ✓ |
| index-HASH.js gzip | 263 B | 263 B | ✓ |
| link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
| routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
| script-HASH.js gzip | 383 B | 383 B | ✓ |
| withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 14.3 kB | 14.3 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 459 B | 459 B | ✓ |
| Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| index.html gzip | 530 B | 530 B | ✓ |
| link.html gzip | 545 B | 545 B | ✓ |
| withRouter.html gzip | 525 B | 525 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| buildDuration | 18.3s | 18.1s | -220ms |
| buildDurationCached | 3.7s | 3.7s | |
| nodeModulesSize | 359 MB | 359 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 3.453 | 3.457 | 0 |
| / avg req/sec | 724.09 | 723.13 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.546 | 1.565 | |
| /error-in-render avg req/sec | 1617.43 | 1597.44 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
| main-HASH.js gzip | 27.4 kB | 27.4 kB | ✓ |
| webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
| Overall change | 71.3 kB | 71.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
| _error-HASH.js gzip | 180 B | 180 B | ✓ |
| amp-HASH.js gzip | 305 B | 305 B | ✓ |
| css-HASH.js gzip | 321 B | 321 B | ✓ |
| dynamic-HASH.js gzip | 2.36 kB | 2.36 kB | ✓ |
| head-HASH.js gzip | 342 B | 342 B | ✓ |
| hooks-HASH.js gzip | 911 B | 911 B | ✓ |
| image-HASH.js gzip | 4.98 kB | 4.98 kB | ✓ |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.21 kB | 2.21 kB | ✓ |
| routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
| script-HASH.js gzip | 375 B | 375 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 14.3 kB | 14.3 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 458 B | 458 B | ✓ |
| Overall change | 458 B | 458 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | jameshfisher/next.js url-should-not-be-used-as-page-path | Change | |
|---|---|---|---|
| index.html gzip | 531 B | 531 B | ✓ |
| link.html gzip | 544 B | 544 B | ✓ |
| withRouter.html gzip | 525 B | 525 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
…ercel#33808) Fixes: vercel#17096 Fixes: vercel#23824 Closes: vercel#33765 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added in vercel#33765 - [x] Errors have helpful link attached (N/A) Co-authored-by: Tim Neutkens <[email protected]> Co-authored-by: JJ Kasper <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17096
Fixes: #23824
Closes: #33765
Bug
fixes #number