update turbopack #60478

sokra · 2024-01-10T15:36:46Z

ijjk · 2024-01-10T15:46:44Z

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js sokra/update-turbopack-25	Change
buildDuration	12.8s	12.6s	N/A
buildDurationCached	7.2s	6.1s	N/A
nodeModulesSize	199 MB	199 MB	✓
nextStartRea..uration (ms)	433ms	422ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sokra/update-turbopack-25	Change
193.HASH.js gzip	181 B	182 B	N/A
3f784ff6-HASH.js gzip	53.3 kB	53.3 kB	N/A
433-HASH.js gzip	28.5 kB	28.6 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	31.8 kB	31.8 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	N/A
Overall change	45.2 kB	45.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sokra/update-turbopack-25	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sokra/update-turbopack-25	Change
_app-HASH.js gzip	194 B	195 B	N/A
_error-HASH.js gzip	183 B	181 B	N/A
amp-HASH.js gzip	504 B	502 B	N/A
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	255 B	253 B	N/A
head-HASH.js gzip	350 B	349 B	N/A
hooks-HASH.js gzip	369 B	369 B	✓
image-HASH.js gzip	4.28 kB	4.28 kB	N/A
index-HASH.js gzip	255 B	256 B	N/A
link-HASH.js gzip	2.61 kB	2.61 kB	✓
routerDirect..HASH.js gzip	312 B	311 B	N/A
script-HASH.js gzip	385 B	383 B	N/A
withRouter-HASH.js gzip	307 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.4 kB	3.4 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sokra/update-turbopack-25	Change
_buildManifest.js gzip	483 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sokra/update-turbopack-25	Change
index.html gzip	529 B	526 B	N/A
link.html gzip	541 B	539 B	N/A
withRouter.html gzip	525 B	523 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sokra/update-turbopack-25	Change
edge-ssr.js gzip	93.8 kB	93.8 kB	N/A
page.js gzip	148 kB	148 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sokra/update-turbopack-25	Change
middleware-b..fest.js gzip	623 B	622 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	37.5 kB	37.5 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	2.07 kB	2.07 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js sokra/update-turbopack-25	Change
app-page-exp...dev.js gzip	169 kB	169 kB	✓
app-page-exp..prod.js gzip	95.3 kB	95.3 kB	✓
app-page-tur..prod.js gzip	96 kB	96 kB	✓
app-page-tur..prod.js gzip	90.6 kB	90.6 kB	✓
app-page.run...dev.js gzip	142 kB	142 kB	✓
app-page.run..prod.js gzip	89.9 kB	89.9 kB	✓
app-route-ex...dev.js gzip	24.1 kB	24.1 kB	✓
app-route-ex..prod.js gzip	16.7 kB	16.7 kB	✓
app-route-tu..prod.js gzip	16.7 kB	16.7 kB	✓
app-route-tu..prod.js gzip	16.3 kB	16.3 kB	✓
app-route.ru...dev.js gzip	23.5 kB	23.5 kB	✓
app-route.ru..prod.js gzip	16.3 kB	16.3 kB	✓
pages-api-tu..prod.js gzip	9.38 kB	9.38 kB	✓
pages-api.ru...dev.js gzip	9.65 kB	9.65 kB	✓
pages-api.ru..prod.js gzip	9.37 kB	9.37 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	22.5 kB	22.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	49.5 kB	49.5 kB	✓
Overall change	940 kB	940 kB	✓

Commit: 6450b0c

ijjk · 2024-01-10T15:49:25Z

Failing test suites

Commit: 6450b0c

pnpm test-dev test/e2e/app-dir/app/index.test.ts

app dir - basic > known bugs > should support React cache > server component client-navigation

Expand output

● app dir - basic › known bugs › should support React cache › server component client-navigation

expect(received).toBe(expected) // Object.is equality

Expected: "0.4450768330682988"
Received: "0.9089708017575158"

  1544 |           const val1 = await browser.elementByCss('#value-1').text()
  1545 |           const val2 = await browser.elementByCss('#value-2').text()
> 1546 |           expect(val1).toBe(val2)
       |                        ^
  1547 |         })
  1548 |
  1549 |         it('client component', async () => {

  at Object.toBe (e2e/app-dir/app/index.test.ts:1546:24)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/rsc-runtime-errors.test.ts

Error overlay - RSC runtime errors > should show runtime errors if invalid client API from node_modules is executed
Error overlay - RSC runtime errors > should show runtime errors if invalid server API from node_modules is executed
Error overlay - RSC runtime errors > should show source code for jsx errors from server component
Error overlay - RSC runtime errors > should show the userland code error trace when fetch failed error occurred

Expand output

● Error overlay - RSC runtime errors › should show runtime errors if invalid client API from node_modules is executed

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:12:19)

● Error overlay - RSC runtime errors › should show runtime errors if invalid server API from node_modules is executed

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:12:19)

● Error overlay - RSC runtime errors › should show source code for jsx errors from server component

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:12:19)

● Error overlay - RSC runtime errors › should show the userland code error trace when fetch failed error occurred

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:12:19)

● Test suite failed to run

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  115 |
  116 | if (typeof afterAll === 'function') {
> 117 |   afterAll(async () => {
      |   ^
  118 |     if (nextInstance) {
  119 |       await nextInstance.destroy()
  120 |       throw new Error(

  at Object.afterAll (lib/e2e-utils.ts:117:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:7:19)

Read more about building and testing Next.js in contributing.md.

sokra added 2 commits January 10, 2024 15:36

update turbopack

9474343

fix test case

6450b0c

sokra requested review from timneutkens, ijjk, shuding, huozhi, a team, feedthejim, ztanner and wyattjoh as code owners January 10, 2024 15:36

ijjk added area: tests created-by: Turbopack team PRs by the Turbopack team. type: next labels Jan 10, 2024

ForsakenHarmony approved these changes Jan 10, 2024

View reviewed changes

sokra enabled auto-merge (squash) January 10, 2024 16:05

kwonoj approved these changes Jan 10, 2024

View reviewed changes

Merge branch 'canary' into sokra/update-turbopack-25

efca3ef

sokra merged commit 990d0a9 into canary Jan 10, 2024
63 of 68 checks passed

sokra deleted the sokra/update-turbopack-25 branch January 10, 2024 17:45

vordgi mentioned this pull request Jan 21, 2024

Remove obsolete ("remove after next minor") #60930

Open

github-actions bot added the locked label Jan 25, 2024

github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update turbopack #60478

update turbopack #60478

sokra commented Jan 10, 2024

ijjk commented Jan 10, 2024

ijjk commented Jan 10, 2024 •

edited

Loading

update turbopack #60478

update turbopack #60478

Conversation

sokra commented Jan 10, 2024

ijjk commented Jan 10, 2024

Stats from current PR

ijjk commented Jan 10, 2024 • edited Loading

Failing test suites

ijjk commented Jan 10, 2024 •

edited

Loading