Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix glob matching of alternatives #6968

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix glob matching of alternatives #6968

merged 2 commits into from
Jan 10, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 9, 2024 •
edited by padmaia
Loading

reland #6839

Closes PACK-2211

@linear Linear
Copy link

linear bot commented Jan 9, 2024

Issue reopened: PACK-2200 Revert "fix glob matching of alternatives"

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:18am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:18am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:18am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:18am
examples-native-web ❌ Failed (Inspect) Jan 10, 2024 10:18am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:18am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:18am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:18am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:18am
rust-docs ❌ Failed (Inspect) Jan 10, 2024 10:18am
turbo-site ✅ Ready (Inspect) Visit Preview Jan 10, 2024 10:18am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@sokra sokra mentioned this pull request Jan 10, 2024
Closed
@sokra sokra marked this pull request as ready for review January 10, 2024 12:22
@sokra sokra requested a review from a team as a code owner January 10, 2024 12:22
@sokra sokra merged commit cf66bb9 into main Jan 10, 2024
50 of 52 checks passed
@sokra sokra deleted the revert-6954-revert-6839-sokra/bugfix-glob-matching branch January 10, 2024 15:29
@sokra sokra mentioned this pull request Jan 10, 2024
Merged
sokra added a commit to vercel/next.js that referenced this pull request Jan 10, 2024
@sokra
update turbopack (#60478)
990d0a9 
* vercel/turborepo#6978 <!-- Tobias Koppers - fix
aggregation of outdated children and collectibles -->
* vercel/turborepo#6968 <!-- Tobias Koppers - fix
glob matching of alternatives -->
* vercel/turborepo#6922 <!-- Tobias Koppers - avoid
using a write lock for root info -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix glob matching of alternatives (vercel/turborepo#6968)
5a843af 
reland vercel/turborepo#6839

Closes PACK-2211
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix glob matching of alternatives (vercel/turborepo#6968)
86ff346 
reland vercel/turborepo#6839

Closes PACK-2211
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix glob matching of alternatives (vercel/turborepo#6968)
d8896f6 
reland vercel/turborepo#6839

Closes PACK-2211
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix glob matching of alternatives (vercel/turborepo#6968)
1e44b6c 
reland vercel/turborepo#6839

Closes PACK-2211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwonoj kwonoj kwonoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @kwonoj