Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change anynymous functions to named functions on examples in the README.md file #6255

Merged

Conversation

j0lvera
Copy link
Contributor

@j0lvera j0lvera commented Feb 11, 2019

This change makes sure all components and functions have a name in the README.md file.

I'm not sure about the names I used, so I'd love some feedback here @timneutkens.

@timneutkens timneutkens changed the title [WIP] Change anynymous functions to named functions on examples in the README.md file [WIP] Change anonymous functions to named functions on examples in the README.md file Feb 11, 2019
@j0lvera j0lvera changed the title [WIP] Change anonymous functions to named functions on examples in the README.md file Change anynymous functions to named functions on examples in the README.md file Feb 11, 2019
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @j0lv3r4. Great PR 🤩

@timneutkens timneutkens merged commit 23c9c0d into vercel:canary Feb 11, 2019
@j0lvera j0lvera deleted the remove-unnamed-functions-references branch February 18, 2019 20:48
@timneutkens timneutkens mentioned this pull request Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants