Update README #9880

soroushchehresa · 2019-12-30T08:44:14Z

Updated all the old function components to arrow function.

ijjk · 2019-12-30T08:49:49Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	soroushchehresa/next.js canary	Change
buildDuration	13.7s	13.9s	⚠️ +213ms
nodeModulesSize	48.9 MB	48.9 MB	-786 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	soroushchehresa/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.44 kB	6.44 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..1db6754d3.js	12 kB	12 kB	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js	10.9 kB	10.9 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..1a41e84e9.js	38.2 kB	38.2 kB	✓
de003c3a9d30..84e9.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js	126 kB	126 kB	✓
framework.HASH.js gzip	39.5 kB	39.5 kB	✓
Overall change	206 kB	206 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	soroushchehresa/next.js canary	Change
main-HASH.module.js	14.4 kB	14.4 kB	✓
main-HASH.module.js gzip	5.42 kB	5.42 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..b9.module.js	14.9 kB	14.9 kB	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..3c.module.js	33.2 kB	33.2 kB	✓
de003c3a9d30..dule.js gzip	12.6 kB	12.6 kB	✓
framework.HASH.module.js	126 kB	126 kB	✓
framework.HA..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	soroushchehresa/next.js canary	Change
polyfills-HASH.js	15.3 kB	15.3 kB	✓
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	15.3 kB	15.3 kB	✓

Client Pages

	zeit/next.js canary	soroushchehresa/next.js canary	Change
_app.js	2.94 kB	2.94 kB	✓
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js	10.4 kB	10.4 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js	1.44 kB	1.44 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	6.88 kB	6.88 kB	✓
link.js gzip	2.93 kB	2.93 kB	✓
routerDirect.js	411 B	411 B	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js	421 B	421 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	soroushchehresa/next.js canary	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	757 B	757 B	✓
_error.module.js	7.35 kB	7.35 kB	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js	651 B	651 B	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js	276 B	276 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js	5.54 kB	5.54 kB	✓
link.module.js gzip	2.49 kB	2.49 kB	✓
routerDirect.module.js	383 B	383 B	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.module.js	394 B	394 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	16.1 kB	16.1 kB	✓

Client Build Manifests

	zeit/next.js canary	soroushchehresa/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	soroushchehresa/next.js canary	Change
index.html	4.06 kB	4.06 kB	✓
index.html gzip	1.04 kB	1.04 kB	✓
link.html	4.11 kB	4.11 kB	✓
link.html gzip	1.04 kB	1.04 kB	✓
withRouter.html	4.12 kB	4.12 kB	✓
withRouter.html gzip	1.03 kB	1.03 kB	✓
Overall change	12.3 kB	12.3 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	soroushchehresa/next.js canary	Change
buildDuration	14.4s	14.3s	-117ms
nodeModulesSize	48.9 MB	48.9 MB	-786 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	soroushchehresa/next.js canary	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.44 kB	6.44 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..1db6754d3.js	12 kB	12 kB	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js	10.9 kB	10.9 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..1a41e84e9.js	38.2 kB	38.2 kB	✓
de003c3a9d30..84e9.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js	126 kB	126 kB	✓
framework.HASH.js gzip	39.5 kB	39.5 kB	✓
Overall change	206 kB	206 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	soroushchehresa/next.js canary	Change
main-HASH.module.js	14.4 kB	14.4 kB	✓
main-HASH.module.js gzip	5.42 kB	5.42 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..b9.module.js	14.9 kB	14.9 kB	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..3c.module.js	33.2 kB	33.2 kB	✓
de003c3a9d30..dule.js gzip	12.6 kB	12.6 kB	✓
framework.HASH.module.js	126 kB	126 kB	✓
framework.HA..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	soroushchehresa/next.js canary	Change
polyfills-HASH.js	15.3 kB	15.3 kB	✓
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	15.3 kB	15.3 kB	✓

Client Pages

	zeit/next.js canary	soroushchehresa/next.js canary	Change
_app.js	2.94 kB	2.94 kB	✓
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js	10.4 kB	10.4 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js	1.44 kB	1.44 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	6.88 kB	6.88 kB	✓
link.js gzip	2.93 kB	2.93 kB	✓
routerDirect.js	411 B	411 B	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js	421 B	421 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	soroushchehresa/next.js canary	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	757 B	757 B	✓
_error.module.js	7.35 kB	7.35 kB	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js	651 B	651 B	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js	276 B	276 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js	5.54 kB	5.54 kB	✓
link.module.js gzip	2.49 kB	2.49 kB	✓
routerDirect.module.js	383 B	383 B	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.module.js	394 B	394 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	16.1 kB	16.1 kB	✓

Client Build Manifests

	zeit/next.js canary	soroushchehresa/next.js canary	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	soroushchehresa/next.js canary	Change
_error.js	299 kB	299 kB	✓
_error.js gzip	78.9 kB	78.9 kB	✓
hooks.html	4.19 kB	4.19 kB	✓
hooks.html gzip	1.07 kB	1.07 kB	✓
index.js	299 kB	299 kB	✓
index.js gzip	79.1 kB	79.1 kB	✓
link.js	306 kB	306 kB	✓
link.js gzip	81.3 kB	81.3 kB	✓
routerDirect.js	300 kB	300 kB	✓
routerDirect.js gzip	79.2 kB	79.2 kB	✓
withRouter.js	299 kB	299 kB	✓
withRouter.js gzip	79.3 kB	79.3 kB	✓
Overall change	1.51 MB	1.51 MB	✓

Commit: ef96684

timneutkens · 2019-12-30T09:56:28Z

Current readme is correct and expected to use functions.

soroushchehresa · 2019-12-30T11:37:10Z

@timneutkens First of all, Thanks for your quick response.
I did not want to correct current readme I just wanted to improve the examples by better javascript syntax!
I understood from your comment you preferred to use:

function Test () {
  return (
    // something
  );
}

Instead of using the arrow functions:

const Test = () => // something

Can I know your reasons? I'm so curious :)

timneutkens · 2020-01-01T12:32:15Z

It was implemented in #6255 and there's no reason to have arrow functions when named functions suffice.

soroushchehresa added 3 commits December 30, 2019 11:21

Update custom error handling component

c7cd40a

Update old functions to arrow function

c80026d

Fix

ef96684

soroushchehresa requested review from ijjk, lfades, Timer and timneutkens as code owners December 30, 2019 08:44

timneutkens closed this Dec 30, 2019

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README #9880

Update README #9880

soroushchehresa commented Dec 30, 2019

ijjk commented Dec 30, 2019

timneutkens commented Dec 30, 2019

soroushchehresa commented Dec 30, 2019

timneutkens commented Jan 1, 2020

Update README #9880

Update README #9880

Conversation

soroushchehresa commented Dec 30, 2019

ijjk commented Dec 30, 2019

Stats from current PR

timneutkens commented Dec 30, 2019

soroushchehresa commented Dec 30, 2019

timneutkens commented Jan 1, 2020