The logo is not centered vertically #71
Comments
thien-do
pushed a commit
to thien-do/nextra
that referenced
this issue
Jan 27, 2021
This is my proposal to fix the issue that a logo with SVG image won't be centered vertically properly as described in vercel/swr-site#71
Merged
shuding
added a commit
that referenced
this issue
Jun 6, 2021
* feat: Add japanese translate (#47) * doc: translate "Global Configuration" page into Japanese (#48) * doc: translate "Data-Fetching" page into Japanese (#50) * docs: Add Japanese markdown or mdx files (#54) * doc: translate "API Options" page into Japanese (#56) * doc: translate "Top" page into Japanese (#55) * doc: translate "Conditional Fetching" page into Japanese (#57) * doc: translate "mutation" page into Japanese (#58) * doc: translate "Suspense" page into Japanese (#60) * doc: translate "Change Log" page into Japanese (#62) * doc: translate "Prefetching Data" page into Japanese (#59) * doc: translate "Automatic Revalidation" page into Japanese (#63) * doc: translate "Getting Started" page into Japanese (#61) * doc: translate "Arguments" page into Japanese (#64) * doc: translate the swr title into Japanese (#71) * doc: translate "Advanced Performance" page into Japanese (#65) * doc: translate "Error Handling" page into Japanese (#69) * doc: translate the side menu into Japanese (#72) * doc: translate "Usage with Next.js" page into Japanese (#70) * doc: translate "pagination" page into Japanese(#73) * doc: proofread "Top" page (#77) * doc: proofread "Global Configuration" page (#81) * doc: proofread "Getting Started" page (#79) * doc: proofread "Error Handling" page (#83) * doc: proofread "Conditional Fetching" page (#85) * doc: proofread "Pagination" page (#87) * doc: proofread "Usage with Next.js" page (#89) * docs: proofread the doc pages (#91) * fix: resolve conflicts (#93) * Fix code example in data-fetching.zh-CN.mdx (#90) * Add license (#93) * Add license * Update license.md Co-authored-by: Paco <[email protected]> Co-authored-by: Shu Ding <[email protected]> Co-authored-by: Paco <[email protected]> * update perf page (#92) * I18n: Spanish (#96) * feat: added support for Spanish language * doc(language): now the footer text is on Spanish * docs(language): I18: Snpanish * docs(language): Added metadata Spanish * docs(language): I18 index spanish page * docs(language): I18 Getting started to spanish * docs(language): I18 Change log page to Spanish * feat(I18): Add metadata related to the example to Spanish * docs(I18): Basic use to the Spanish * docs(I18): Auth page to Spanish * docs(I18): Handleing error page to Spanish * docs(I18): Inifinite loading page to Spanish * feat(I18-spanish): added metadata related with advances section * docs(I18): Translated to Spanish * docs(I18): Added metadata related with documentation section * refactor: fix typo * docs(I18): Option translated to Spanish * docs(I18): Configuration global page translated to Spanish * docs(I18): Data fetching page translated to Spanish * docs:(I18): Error handling page translated to Spanish * refactor: Fixy typo * docs(I18): Automatic revalidation page translated to Spanish * docs(I18): Conditional data fetching page translated to Spanish * docs(I18): Arguments page translated to Spanish * docs(I18) Mutation page translated to Spanish * docs(I18): Pagination page translated to Spanish * docs(I18): Prefetching page translated to Spanish * docs(I18): Usage with Next.js page translated to Spanish * docs(I18): Suspense page translated to Spanish * refactor: performance page * docs(readme): Improving credits and add one more. (#97) * i18n: add Japanese Co-authored-by: Fang Lu <[email protected]> Co-authored-by: Joe Cohen <[email protected]> Co-authored-by: Shu Ding <[email protected]> Co-authored-by: Paco <[email protected]> Co-authored-by: Markoz Peña <[email protected]> * Revert "fix: resolve conflicts (#93)" This reverts commit b29c7b8. * feat(i18n): add Japanese (#95) * doc: update translation of "Performance" page (#98) * doc: add Japanese translators to README.md (#99) * doc: fix the feature section of top page (#101) Co-authored-by: Tomohiro (Tomo) SHIOYA <[email protected]> Co-authored-by: Fang Lu <[email protected]> Co-authored-by: Joe Cohen <[email protected]> Co-authored-by: Shu Ding <[email protected]> Co-authored-by: Paco <[email protected]> Co-authored-by: Markoz Peña <[email protected]>
axeincode
pushed a commit
to axeincode/nextra
that referenced
this issue
Oct 10, 2024
This is my proposal to fix the issue that a logo with SVG image won't be centered vertically properly as described in vercel/swr-site#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I understand that this is actually an issue of nextra (in which I'll propose a fix later). It's just easier and more clear to describe the issue based on a real project like this.
So the issue is the logo is not centered vertically if you use an SVG logo. It's just a bit off. I believe this is because the "a" tag is an inline element, so the height of its "div" wrapper is not correct. I took 2 screenshots for more detail. The size of the "a" element is 24px (correct) but the size of the wrapper is 27px (incorrect) due to "a" being an inline element (vertical align and base line etc)
The text was updated successfully, but these errors were encountered: