Improves Spanish translated and little more #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/swr-site/8SQW9rMbAmqgq6iKGneqkdpV5KjV |
shuding
reviewed
Jun 6, 2021
| @@ -19,7 +19,7 @@ const TITLE_WITH_TRANSLATIONS = { | |||
| export default { | |||
| repository: 'https://github.com/vercel/swr', | |||
| docsRepository: 'https://github.com/vercel/swr-site', | |||
| titleSuffix: ' – SWR', | |||
| titleSuffix: '', // It was left empty with the intention of avoiding duplicated title on homepage ---> SWR - SWR | |||
There was a problem hiding this comment.
This is intentional, so on subpages it will be something like "Get Started — SWR" 🤔
ernestd
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on improves Spanish translated, and opt use of the impersonal language. Thank You, @ernestd for the observation on typos mentioned #96.
Bonus 😃
I took care of the little problem of the duplicated title on the home page. Basically, opt to leave the value of
titleSuffixwith an empty string, my intention was to omit the property but the default value nextra is used title home page.Closes #82