Rename go module to allow command line installs #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/2GRstQRH3MyhQE86TzwPzkCeodJZ |
|
I think this complicates #397 quite a bit? |
|
we should do it for the go doc though I guess |
|
I think you could probably work out if the binary is in $GOBIN and prompt for go install for the latest version in that instance? |
|
We should do this, but probs easier to just take main and search + replace at this point. |
|
Yeah. Almost certainly is. I'll get it rebased on Monday for you. Update: rebased this now. |
The `go install` command doesn't like it when the go.mod file declares a different path to the module, to the actual path. e.g. ``` $ go install github.com/vercel/turborepo/cli/cmd/turbo@latest go install: github.com/vercel/turborepo/cli/cmd/turbo@latest: github.com/vercel/turborepo/[email protected]: parsing go.mod: module declares its path as: turbo but was required as: github.com/vercel/turborepo/cli ``` This PR renames the go module to match the path name, as go expects. This allows the turborepo CLI to be installed via `go install`
jaredpalmer
approved these changes
Feb 8, 2022
jaredpalmer
added
the
pr: automerge
sokra
added a commit
that referenced
this pull request
Oct 25, 2022
so we don't really have to benchmark that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go installcommand doesn't like it when the go.mod filedeclares a different path to the module, to the actual path.
e.g.
This PR renames the go module to match the path name, as go expects. This allows the turborepo CLI to be installed via
go install