Improve-updater #397
Closed
Improve-updater #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaredpalmer
commented
Dec 21, 2021
•
jaredpalmer
commented
- Add updater
- Correctly show the installation instructions depending on where turbo is installed
- This requires porting the following libraries to Golang:
- https://github.com/sindresorhus/is-installed-globally/blob/main/index.js
- https://github.com/LitoMore/is-yarn-global
- https://github.com/sindresorhus/is-path-inside/blob/main/index.js
- https://github.com/sindresorhus/global-dirs/blob/main/index.js
- This requires porting the following libraries to Golang:
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/AZ5qBsqEDRP5RcPotqbXbAUdA671 |
weyert
reviewed
Dec 22, 2021
Co-authored-by: Weyert de Boer <[email protected]>
|
Closing for when we do cobra |
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.