Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove __internal_nextjs_integration_test compile-time feature #5295

Merged
merged 1 commit into from
Jun 16, 2023
Merged

remove __internal_nextjs_integration_test compile-time feature #5295

merged 1 commit into from
Jun 16, 2023

Conversation

wbinnssmith
Copy link
Member

No description provided.

@wbinnssmith wbinnssmith requested review from a team as code owners June 14, 2023 16:43
@vercel
Copy link

vercel bot commented Jun 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 4:44pm
examples-cra-web 🔄 Building (Inspect) Visit Preview Jun 14, 2023 4:44pm
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview Jun 14, 2023 4:44pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 4:44pm
examples-native-web 🔄 Building (Inspect) Visit Preview Jun 14, 2023 4:44pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview Jun 14, 2023 4:44pm
examples-vite-web 🔄 Building (Inspect) Visit Preview Jun 14, 2023 4:44pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 4:44pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2023 4:44pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2023 4:44pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2023 4:44pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@mehulkar mehulkar removed their request for review June 14, 2023 16:52
@github-actions
Copy link
Contributor

Linux Benchmark for 147610d

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 925.93ms ± 2.16ms 944.70ms ± 5.42ms +2.03% +0.39%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9399.88µs ± 58.21µs 9439.10µs ± 39.95µs +0.42%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8625.94µs ± 78.02µs 8598.63µs ± 47.15µs -0.32%
bench_startup/Turbopack CSR/1000 modules 925.93ms ± 2.16ms 944.70ms ± 5.42ms +2.03% +0.39%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 063247c into main Jun 16, 2023
@sokra sokra deleted the wbinnssmith/remove-test-flag branch June 16, 2023 07:49
@sokra sokra mentioned this pull request Jun 21, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Jun 22, 2023
@sokra
add edge rendering for app dir for Turbopack (#51631)
99ec305 
## What

* reland #50830 
* remove Object.hasOwn
* fix CSS chunks in edge runtime

## Turbopack Changes

* vercel/turborepo#5253 <!-- OJ Kwon -
fix(turbopack): enable runtime flag -->
* vercel/turborepo#5295 <!-- Will Binns-Smith -
remove `__internal_nextjs_integration_test` compile-time feature -->
* vercel/turborepo#4362 <!-- Donny/강동윤 - Make build
faster -->
* vercel/turborepo#5352 <!-- Tobias Koppers - only
wait for JS chunks in none runtime backend -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@kwonoj kwonoj kwonoj approved these changes

@arlyon arlyon Awaiting requested review from arlyon arlyon is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wbinnssmith @mehulkar @kwonoj @sokra