Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only wait for JS chunks in none runtime backend #5352

Merged
merged 1 commit into from
Jun 21, 2023
Merged

only wait for JS chunks in none runtime backend #5352

merged 1 commit into from
Jun 21, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 21, 2023 •
edited
Loading

Description

When rendering RSC with CSS in edge, there might be CSS chunks in the none runtime, which shouldn't be waited for.

@vercel
Copy link

vercel bot commented Jun 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 7:49pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 7:49pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 7:49pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 7:49pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 7:49pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 7:49pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 7:49pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 7:49pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 21, 2023 7:49pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 7:49pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2023 7:49pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for dc405e3

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7906.18µs ± 94.45µs 8176.62µs ± 38.14µs +3.42% +0.07%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6916.00µs ± 194.73µs 7728.83µs ± 96.63µs +11.75% +3.15%
bench_startup/Turbopack CSR/1000 modules 977.06ms ± 1.28ms 953.38ms ± 1.46ms -2.42% -1.87%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7906.18µs ± 94.45µs 8176.62µs ± 38.14µs +3.42% +0.07%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6916.00µs ± 194.73µs 7728.83µs ± 96.63µs +11.75% +3.15%
bench_startup/Turbopack CSR/1000 modules 977.06ms ± 1.28ms 953.38ms ± 1.46ms -2.42% -1.87%

@sokra sokra changed the title avoid waiting for css in none runtime backend only wait for JS chunks in none runtime backend Jun 21, 2023
@sokra sokra requested a review from alexkirsz June 21, 2023 19:52
@sokra sokra marked this pull request as ready for review June 21, 2023 19:53
@sokra sokra requested a review from a team as a code owner June 21, 2023 19:53
@github-actions
Copy link
Contributor

Linux Benchmark for 10acc3d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9313.37µs ± 82.12µs 9326.84µs ± 39.32µs +0.14%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8608.07µs ± 64.88µs 8702.97µs ± 149.61µs +1.10%
bench_startup/Turbopack CSR/1000 modules 1110.04ms ± 1.14ms 1107.20ms ± 1.85ms -0.26%

@github-actions
Copy link
Contributor

MacOS Benchmark for 10acc3d

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 27.24ms ± 0.67ms 24.92ms ± 0.16ms -8.51% -2.60%
bench_startup/Turbopack CSR/1000 modules 9656.16ms ± 856.26ms 4087.59ms ± 137.90ms -57.67% -45.07%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.08ms ± 0.30ms 26.91ms ± 0.38ms +3.18%
bench_hmr_to_eval/Turbopack CSR/1000 modules 27.24ms ± 0.67ms 24.92ms ± 0.16ms -8.51% -2.60%
bench_startup/Turbopack CSR/1000 modules 9656.16ms ± 856.26ms 4087.59ms ± 137.90ms -57.67% -45.07%

@sokra sokra merged commit ee6683e into main Jun 21, 2023
@sokra sokra deleted the sokra/none-runtime-css branch June 21, 2023 21:11
@sokra sokra mentioned this pull request Jun 21, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Jun 22, 2023
@sokra
add edge rendering for app dir for Turbopack (#51631)
99ec305 
## What

* reland #50830 
* remove Object.hasOwn
* fix CSS chunks in edge runtime

## Turbopack Changes

* vercel/turborepo#5253 <!-- OJ Kwon -
fix(turbopack): enable runtime flag -->
* vercel/turborepo#5295 <!-- Will Binns-Smith -
remove `__internal_nextjs_integration_test` compile-time feature -->
* vercel/turborepo#4362 <!-- Donny/강동윤 - Make build
faster -->
* vercel/turborepo#5352 <!-- Tobias Koppers - only
wait for JS chunks in none runtime backend -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
only wait for JS chunks in none runtime backend (vercel/turborepo#5352)
e7e99ba 
### Description

When rendering RSC with CSS in edge, there might be CSS chunks in the
none runtime, which shouldn't be waited for.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
only wait for JS chunks in none runtime backend (vercel/turborepo#5352)
401b716 
### Description

When rendering RSC with CSS in edge, there might be CSS chunks in the
none runtime, which shouldn't be waited for.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
only wait for JS chunks in none runtime backend (vercel/turborepo#5352)
17b4617 
### Description

When rendering RSC with CSS in edge, there might be CSS chunks in the
none runtime, which shouldn't be waited for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @alexkirsz