fix: stop targeting all packages with --since if no changes #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejcox
changed the title
stevejcox
changed the title
stevejcox
changed the title
|
Deployment failed with the following error: |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/BcHRMDZvUL2Rqo4gmp7Rv2NZGGvw |
gsoltis
added
the
area: ergonomics
jaredpalmer
approved these changes
Feb 8, 2022
jaredpalmer
added
the
pr: automerge
|
@jaredpalmer - anything I need to do to merge this? Looks like Kodiak is stuck waiting on checks that need manual approval to run? |
|
nope, I had to press "approve and run again" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
If no changes are made to any package,
--sincewill target all packages.Expected Behavior
If no changes are made to any package, running
--sinceshould target no packages.To Reproduce
Branch off of main and attempt a build with
turbo run build --since=main.Implementation Detail
This PR removes the loop which populates all packages if git diff turns up empty.
@jaredpalmer - let me know if this is currently intended behavior, it's unclear what the original intent of this loop was.