Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop targeting all packages with --since if no changes #637

Merged
merged 10 commits into from
Feb 9, 2022
Merged

fix: stop targeting all packages with --since if no changes #637

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
96f9f0d
fix: stop all packages in --since if not changes
stevejcox Jan 29, 2022
820a4ac
Only skip loop if runOptions.since was set
stevejcox Jan 29, 2022
42081cb
Merge branch 'main' into resolve-since-package-filter
stevejcox Feb 3, 2022
284dd5f
Merge branch 'main' into resolve-since-package-filter
jaredpalmer Feb 3, 2022
9d9e63e
Merge branch 'main' into resolve-since-package-filter
stevejcox Feb 5, 2022
097eae2
Merge branch 'main' into resolve-since-package-filter
jaredpalmer Feb 5, 2022
9f84406
Merge branch 'main' into resolve-since-package-filter
jaredpalmer Feb 8, 2022
24d38a3
Merge branch 'main' into resolve-since-package-filter
kodiakhq[bot] Feb 8, 2022
c47aa9b
Merge branch 'main' into resolve-since-package-filter
kodiakhq[bot] Feb 8, 2022
31946f3
Merge branch 'main' into resolve-since-package-filter
kodiakhq[bot] Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/internal/run/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ func (c *RunCommand) Run(args []string) int {
c.Ui.Output(fmt.Sprintf(ui.Dim("• Packages changed since %s: %s"), runOptions.since, strings.Join(filteredPkgs.UnsafeListOfStrings(), ", ")))
} else if scopePkgs.Len() > 0 {
filteredPkgs = scopePkgs
} else {
} else if runOptions.since == "" {
for _, f := range ctx.PackageNames {
filteredPkgs.Add(f)
}
Expand Down