fix glob matching of alternatives #6839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
sokra
commented
Dec 20, 2023
| }; | ||
|
|
||
| let c = &chars[self.cursor.cur_cursor()..end] |
There was a problem hiding this comment.
This is unused, but it doesn't really make sense to use the path cursor to index chars
| } | ||
| } else if let Some(alternative) = alternatives.get(self.cursor.cur_cursor()) { |
There was a problem hiding this comment.
path cursor can't be used to index alternatives list
🟢 Turbopack Benchmark CI successful 🟢Thanks |
sokra
commented
Dec 20, 2023
Comment on lines
+272
to
+274
| let Ok(Some(_)) = self.cursor.next_boundary(self.path, 0) else { | ||
| return None; | ||
| }; |
There was a problem hiding this comment.
This is just shorter and cleaner
There was a problem hiding this comment.
yes I'm always forgetting there's let..else syntax
|
✅ This change can build |
|
kwonoj
reviewed
Dec 22, 2023
Comment on lines
+272
to
+274
| let Ok(Some(_)) = self.cursor.next_boundary(self.path, 0) else { | ||
| return None; | ||
| }; |
There was a problem hiding this comment.
yes I'm always forgetting there's let..else syntax
| #[case::alternatives_nested1("{a,b/c,d/e/{f,g/h}}", "a")] | ||
| #[case::alternatives_nested2("{a,b/c,d/e/{f,g/h}}", "b/c")] | ||
| #[case::alternatives_nested3("{a,b/c,d/e/{f,g/h}}", "d/e/f")] | ||
| #[case::alternatives_nested4("{a,b/c,d/e/{f,g/h}}", "d/e/g/h")] | ||
| // #[case::alternatives_chars("[abc]", "b")] |
There was a problem hiding this comment.
is this inteded to be commented?
There was a problem hiding this comment.
This isn't supported in the glob parsing yet. We might want to uncomment that test case once we implement that.
kdy1
approved these changes
Jan 4, 2024
Zertsov
pushed a commit
that referenced
this pull request
Jan 5, 2024
### Description The unicode refactoring introduced some bugs in matching of alternatives Closes PACK-2172
sokra
added a commit
that referenced
this pull request
Jan 8, 2024
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 10, 2024
* vercel/turborepo#6720 <!-- Tobias Koppers - fix weird local name, add tests --> * vercel/turborepo#6832 <!-- Leah - fix(turbopack-ecmascript): make sure async module wrapper is always generated --> * ~vercel/turborepo#6885 <!-- Tobias Koppers - fix aggregation of outdated children and collectibles --> * ~vercel/turborepo#6839 <!-- Tobias Koppers - fix glob matching of alternatives -->~ * vercel/turborepo#6884 <!-- Donny/강동윤 - Update `swc_core` to `v0.87.16` --> * vercel/turborepo#6964 <!-- Tobias Koppers - Reduce calls, tasks and duplicate work -->
sokra
added a commit
that referenced
this pull request
Jan 10, 2024
Zertsov
pushed a commit
that referenced
this pull request
Jan 10, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description The unicode refactoring introduced some bugs in matching of alternatives Closes PACK-2172
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description The unicode refactoring introduced some bugs in matching of alternatives Closes PACK-2172
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description The unicode refactoring introduced some bugs in matching of alternatives Closes PACK-2172
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description The unicode refactoring introduced some bugs in matching of alternatives Closes PACK-2172
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The unicode refactoring introduced some bugs in matching of alternatives
Closes PACK-2172