Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace Server add focus mode #8153

Merged
merged 3 commits into from
May 17, 2024
Merged

Trace Server add focus mode #8153

merged 3 commits into from
May 17, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented May 15, 2024

Description

When appending a ! to the search it shows only these spans and not the whole tree

Testing Instructions

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:47pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:47pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:47pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:47pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:47pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:47pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 2:47pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 2:47pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 2:47pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 2:47pm

Copy link
Contributor

github-actions bot commented May 15, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 15, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Contributor

github-actions bot commented May 15, 2024

⚠️ This change may fail to build next-swc.

Logs

error: failed to select a version for `swc_common`.
    ... required by package `swc_core v0.92.5`
    ... which satisfies dependency `swc_core = "^0.92.5"` of package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=8676b0fd07893dffda91ad6d1d193f4bbe8a166b#11e59b96)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.33.26` are: 0.33.26

all possible versions conflict with previously selected packages.

  previously selected package `swc_common v0.33.24`
    ... which satisfies dependency `swc_common = "^0.33.20"` (locked to 0.33.24) of package `swc_core v0.90.33`
    ... which satisfies dependency `swc_core = "^0.90.33"` (locked to 0.90.33) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_common` which could resolve this conflict

See job summary for details

@timneutkens
Copy link
Member

timneutkens commented May 15, 2024

Maybe use the " quote wrapped case instead, that's well known by many tools i.e. Google etc. something people know already

@timneutkens
Copy link
Member

Actually maybe we can make it a value we can pass instead? That way I can add a UI element for it, similar to what VS Code does for search

@sokra
Copy link
Member Author

sokra commented May 17, 2024

Actually maybe we can make it a value we can pass instead? That way I can add a UI element for it, similar to what VS Code does for search

Yes, you can add that as follow-up

@sokra sokra merged commit 84ef2da into main May 17, 2024
47 of 50 checks passed
@sokra sokra deleted the sokra/trace-viewer-focus branch May 17, 2024 15:27
Neosoulink pushed a commit to Neosoulink/turbo that referenced this pull request Jun 14, 2024
### Description

When appending a `!` to the search it shows only these spans and not the
whole tree

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

When appending a `!` to the search it shows only these spans and not the
whole tree

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

When appending a `!` to the search it shows only these spans and not the
whole tree

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

When appending a `!` to the search it shows only these spans and not the
whole tree

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

When appending a `!` to the search it shows only these spans and not the
whole tree

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants