support black password #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wey-gu
reviewed
Oct 13, 2022
| @@ -469,9 +469,6 @@ func validateFlags() { | |||
| if len(*username) == 0 { | |||
| log.Panicf("Error: argument username is empty!") | |||
| } | |||
| if len(*password) == 0 { | |||
| log.Panicf("Error: argument password is empty!") | |||
There was a problem hiding this comment.
maybe we could use a warning log instead of removing the panic logging? Thus those who missed the password field accidentally could be hinted, too?
There was a problem hiding this comment.
I don't think so, as we could create an user without password.
BLANK is a password but the password is invalid, so "invalid password" makes sense.
jievince
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #178