Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support black password #177

Merged
merged 1 commit into from
Oct 30, 2022
Merged

support black password #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,6 @@ func validateFlags() {
if len(*username) == 0 {
log.Panicf("Error: argument username is empty!")
}
if len(*password) == 0 {
log.Panicf("Error: argument password is empty!")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could use a warning log instead of removing the panic logging? Thus those who missed the password field accidentally could be hinted, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, as we could create an user without password.

BLANK is a password but the password is invalid, so "invalid password" makes sense.

}

if *enableSsl {
if *sslRootCAPath == "" {
Expand Down