Docker Push with arm64 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable nightly docker build push - us v3 and buildx for docker build in release with arm64
wey-gu
commented
Nov 16, 2022
| type=semver,pattern=v{{version}} | ||
| # v3.0 | ||
| type=semver,pattern=v{{major}}.{{minor}} | ||
| # v3.0.0 |
There was a problem hiding this comment.
pattern={raw} will do the same job as type=semver,pattern=v{{major}}.{{minor}}, but I left it in this way as explicit seems to be better.
|
Is there a specific reason why this cannot be merged? It seems to have passed all checks. Without this, we cannot run Nebula on Apple silicon at all. Thanks! |
jievince
reviewed
Dec 1, 2022
.github/workflows/release.yml
Outdated
Comment on lines
66
to
67
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v1 |
There was a problem hiding this comment.
Why need QEMU here?
Golang binary could be cross-compiled. 🤔
There was a problem hiding this comment.
Sorry, I blindly referred this from the previous PR, will remove this step :D
|
Hey, @codegladiator007 now the nightly image is dual arch :) have fun!!!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #188
This also fix the nebula-docker-compose console container error in Apple Chip macOS and Respberry Pi