Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Push with arm64 #189

Merged
merged 3 commits into from
Dec 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ jobs:
name: build docker image
runs-on: ubuntu-latest
steps:
- name: Set up QEMU
uses: docker/setup-qemu-action@v1
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
- name: Log into registry
Expand All @@ -24,3 +22,4 @@ jobs:
with:
platforms: linux/amd64,linux/arm64
tags: vesoft/nebula-console/nightly, vesoft/nebula-console/v3-nightly
push: true
35 changes: 28 additions & 7 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,34 @@ jobs:
name: build docker image
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Build and push Docker images
uses: docker/build-push-action@v1
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
- name: Docker meta
id: meta
uses: docker/metadata-action@v3
with:
images: |
vesoft/nebula-console
tags: |
# git tag & latest coverred
type=ref,event=tag
# git branch
type=ref,event=branch
# v3
type=semver,pattern=v{{version}}
# v3.0
type=semver,pattern=v{{major}}.{{minor}}
# v3.0.0
Copy link
Contributor Author

@wey-gu wey-gu Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pattern={raw} will do the same job as type=semver,pattern=v{{major}}.{{minor}}, but I left it in this way as explicit seems to be better.

ref: https://github.com/docker/metadata-action

type=semver,pattern=v{{major}}.{{minor}}.{{patch}}
- name: Log into registry
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
repository: vesoft/nebula-console
tags: v3,latest
tag_with_ref: true
add_git_labels: true
- name: Build and push Docker images
uses: docker/build-push-action@v3
with:
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}