Update to 2.3.1 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Powershell translator added.
* Add Translator.inspect * Apply changes following review Co-authored-by: Frédéric Collonval <[email protected]>
Convert `Path` to `str` when received. Fixes nteract#543.
Allow `pathlib.Path` paths
Update extending-entry-points.rst
Cleanup of CoC in CONTRIBUTING.md
set base docs python to 3 in tox.ini
typo fix in binder/cli-simple/cli_example.ipynb
* prevent exception when paramaters yaml is empty Fix nteract#558 * add cli test for empty parameters yaml
jpugliesi
requested review from
devstein,
jay-bhambhani and
aleksandrpetukhov
aleksandrpetukhov
approved these changes
Jan 25, 2021
devstein
approved these changes
Jan 25, 2021
Comment on lines
+13
to
+31
| def any_tagged_cell(nb, tag): | ||
| """Whether the notebook contains at least one cell tagged ``tag``? | ||
|
|
||
| Parameters | ||
| ---------- | ||
| nb : nbformat.NotebookNode | ||
| The notebook to introspect | ||
| tag : str | ||
| The tag to look for | ||
|
|
||
| Returns | ||
| ------- | ||
| bool | ||
| Whether the notebook contains a cell tagged ``tag``? | ||
| """ | ||
| return any([tag in cell.metadata.tags for cell in nb.cells]) | ||
|
|
||
|
|
||
| def find_first_tagged_cell_index(nb, tag): |
There was a problem hiding this comment.
We could probably use these in our papermill wrapper
| @@ -377,6 +547,8 @@ def assign(cls, name, str_val): | |||
| papermill_translators.register("matlab", MatlabTranslator) | |||
| papermill_translators.register(".net-csharp", CSharpTranslator) | |||
| papermill_translators.register(".net-fsharp", FSharpTranslator) | |||
| papermill_translators.register(".net-powershell", PowershellTranslator) | |||
| papermill_translators.register("pysparkkernel", PythonTranslator) | |||
There was a problem hiding this comment.
What about the sparkkernel and SparkK kerenels?
jpugliesi
force-pushed
the
jpugliesi/update
branch
from
89191fb
to
6e4f9a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades papermill to 2.3.1
This contains a fix to an issue introduced in a change to nbformat (see this papermill issue) that will raise an error like:
I'm not sure if this was manifested due to this recent nbformat version bump: https://github.com/viaduct-ai/vml-py/pull/355