Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP concurrent read/write not properly terminated if peer closes connection #1726

Closed
s-ludwig opened this issue Mar 28, 2017 · 2 comments
Closed

TCP concurrent read/write not properly terminated if peer closes connection #1726

s-ludwig opened this issue Mar 28, 2017 · 2 comments
Labels
bug

Comments

@s-ludwig
Copy link
Member

Most likely the cause for #1724. This happens for the libevent and libasync drivers, not for vibe-core.
@s-ludwig s-ludwig added the bug label Mar 28, 2017
s-ludwig added a commit that referenced this issue Mar 28, 2017
@s-ludwig
Add test for #1726.
d5864a4
s-ludwig added a commit that referenced this issue Mar 28, 2017
@s-ludwig
Fix libevent socket event handler.
4ec21b0 
Now always resumes the writer if one is active. Partially resolves issue #1726.
s-ludwig added a commit that referenced this issue Mar 28, 2017
@s-ludwig
Fix libasync socket event handlind and connection close sequence.
c35109c 
Resolves #1726.
@tchaloupka
Copy link
Contributor

Might be related also to #1229

@s-ludwig s-ludwig mentioned this issue Mar 28, 2017
Merged
s-ludwig added a commit that referenced this issue Mar 28, 2017
@s-ludwig
Add test for #1726.
f2b5a8f
s-ludwig added a commit that referenced this issue Mar 28, 2017
@s-ludwig
Fix libevent socket event handler.
213dc22 
Now always resumes the writer if one is active. Partially resolves issue #1726.
s-ludwig added a commit that referenced this issue Mar 28, 2017
@s-ludwig
Fix libasync socket event handlind and connection close sequence.
01ca71b 
Resolves #1726.
s-ludwig added a commit that referenced this issue Mar 28, 2017
@s-ludwig
Add test for #1726.
7787da0
s-ludwig added a commit that referenced this issue Mar 28, 2017
@s-ludwig
Fix libevent socket event handler.
b6135cb 
Now always resumes the writer if one is active. Partially resolves issue #1726.
s-ludwig added a commit that referenced this issue Mar 28, 2017
@s-ludwig
Fix libasync socket event handlind and connection close sequence.
c3d39e0 
Resolves #1726.
s-ludwig added a commit that referenced this issue Mar 29, 2017
@s-ludwig
Merge pull request #1727 from rejectedsoftware/issue_1726_tcp_close
7479a8b 
Fix TCP close behavior in case of cuncurrent read+write operations. Fixes #1726.
@s-ludwig s-ludwig mentioned this issue Mar 29, 2017
Closed
@s-ludwig
Copy link
Member Author

@tchaloupka I think #1229 is something else. It seems to be something specific to the OpenSSL stream implementation. I'll have to try and reproduce it on a Windows machine to be able to say more.

s-ludwig added a commit that referenced this issue Apr 7, 2017
@s-ludwig
Rewrite test for #1726 to be more robust w.r.t. timing. Fixes #1734.
4a2c484
s-ludwig added a commit that referenced this issue Apr 10, 2017
@s-ludwig
Merge pull request #1727 from rejectedsoftware/issue_1726_tcp_close
747b920 
Fix TCP close behavior in case of cuncurrent read+write operations. Fixes #1726.
(cherry picked from commit 7479a8b)

# Conflicts:
#	source/vibe/core/drivers/libasync.d
s-ludwig added a commit that referenced this issue Apr 10, 2017
@s-ludwig
Rewrite test for #1726 to be more robust w.r.t. timing. Fixes #1734.
712b6cb 
(cherry picked from commit 4a2c484)
s-ludwig added a commit to vibe-d/vibe-core that referenced this issue May 16, 2017
@s-ludwig
Add test for vibe-d/vibe.d#1726.
52ead08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s-ludwig @tchaloupka