Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vibe.core.net.1726 fails intermittently when compiled with dmd-2.073.2 and the libevent configuration. #1734

Closed
DBankov opened this issue Apr 7, 2017 · 2 comments

Comments

@DBankov
Copy link
Contributor

DBankov commented Apr 7, 2017

See https://travis-ci.org/rejectedsoftware/vibe.d/jobs/217219176 for а failure example. It seems something is getting slower when compiled with dmd-2.073.2 because if I increase the sleep period from 50 to 500 msec the test succeeds consistently. I'm not sure increasing the sleep period is the correct way to fix this but I'll post a PR with it just in case there is no other fix. BTW release build as well as LDC builds (both debug and release) are working fine.

@s-ludwig
Copy link
Member

s-ludwig commented Apr 7, 2017

I think it would be a good idea to restructure the test slightly, so that it returns as soon as the first task is done. A timer would be used to ensure the test doesn't hang. I'll push a fix.

@DBankov
Copy link
Contributor Author

DBankov commented Apr 7, 2017

Wow that was fast.

And the new code looks a lot better to me.

Thanks for taking a look at this!

s-ludwig added a commit that referenced this issue Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants