Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 510: Support text blocks in Diet templates #514

Closed
wants to merge 75 commits into from

Conversation

nazriel
Copy link
Contributor

@nazriel nazriel commented Feb 10, 2014

Fix issue #510
Again, not sure if it is the best approach.

s-ludwig and others added 30 commits January 27, 2014 21:02
…parseXXX and HTTPServerRequest.bodyReader. Fixes vibe-d#483.
Add NetworkAddress.toString and create a NetworkAddress based overload of connectTCP.
…and add toAddressString.

Also use lower case letters for IPv6 representations (as recommended by RFC5952).

See also vibe-d#485.
- fix field name
- remove unused _in_addr
Fixed compilation on dmd 2.063.2
add Travis CI configuration for unittests
added convenience method for appending to a file...
@s-ludwig
Copy link
Member

I think this partially needs to be built into buildHtmlNodeWriter somehow, because the dot might occur after an argument list: pre(style="fancy").. My first idea was to simply return a bool from buildHtmlNodeWriter whenever the tag is directly followed by a lone ".". If true, the code that is currently in the "blocktag" case would be executed.

Some care needs to be taken to handle anything after the dot correctly:

  • pre.test -> <pre class="test">
  • pre.test. -> <pre class="test"> + block text
  • pre. test -> <pre> + block text (jade apprently ignores the "test" in this case
  • pre(). -> <pre> + block text

I'll prepare a few unit tests in diet.d, so that a proper unit test suite can be started for this.

@nazriel
Copy link
Contributor Author

nazriel commented Feb 10, 2014

Roger that, gonna update it.
Will close it for now

@nazriel nazriel closed this Feb 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants