-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First exchange of Vircadia protocol packets with the Vircadia Web SDK. #1259
Conversation
The following links are available: build (macOS-latest, full) build (ubuntu-18.04, full)
build (windows-latest, full) |
The following links are available:
build (macOS-latest, client) build (macOS-latest, full) build (windows-latest, full) |
The following links are available:
build (macOS-latest, client) build (macOS-latest, full) build (windows-latest, full) |
case SocketType::UDP: | ||
// WEBRTC TODO: The Qt documentation says that the following call shouldn't be used if the UDP socket is connected!!! | ||
// https://doc.qt.io/qt-5/qudpsocket.html#writeDatagram | ||
return _udpSocket.writeDatagram(datagram, sockAddr.getAddress(), sockAddr.getPort()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use writeDatagram
anyway, against the recommendation, then? It seems easy to call write
here as recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the way it's currently done in master
for UDP packets and should be addressed there rather than here.
#1279
|
||
|
||
/// @brief Multiplexes a QUdpSocket and a WebRTCSocket so that they appear as a single QUdpSocket-style socket. | ||
class NetworkSocket : public QObject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps this should inherit from QAbstractSocket instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QAbstractSocket
inherits from QIODevice
and no code from either of these is needed. It's not clear to me whether inheriting from QAbstractSocket
would be beneficial or just overhead and a potential source of problems.
|
||
|
||
/// @brief Provides a QUdpSocket-style interface for using WebRTCDataChannels. | ||
class WebRTCSocket : public QObject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it should inherit from QAbstractSocket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
The following links are available:
build (macOS-latest, client) build (macOS-latest, full) build (windows-latest, full) |
The following links are available:
build (macOS-latest, client) build (macOS-latest, full) build (windows-latest, full) build (ubuntu-18.04, android) |
The following links are available: build (macOS-latest, full) build (ubuntu-18.04, full)
build (ubuntu-18.04, android) |
The following links are available:
build (macOS-latest, full) build (macOS-latest, client) build (ubuntu-18.04, android)
build (windows-latest, full) |
# Conflicts: # libraries/networking/src/webrtc/WebRTCDataChannels.h
The following links are available: build (ubuntu-18.04, full)
build (windows-latest, full) build (ubuntu-18.04, android) |
The following links are available:
build (macOS-latest, client) build (macOS-latest, full) build (windows-latest, full) build (ubuntu-18.04, android) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked fine according to the unit tests on master of the Vircadia Web SDK as of 7/15/2021.
This PR in conjunction with Vircadia-Web-SDK PR vircadia/vircadia-web-sdk#9 implements the first exchange of Vircadia protocol packets with the domain server.
Merge sequence:
webapp
branch.