-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First exchange of Vircadia protocol packets with the Domain server. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ctrlaltdavid
added
needs CR (code review)
needs QA (testing)
enhancement
New feature or request
labels
Jul 1, 2021
digisomni
requested changes
Jul 6, 2021
digisomni
approved these changes
Jul 6, 2021
digisomni
added
CR approved
At least one code reviewer has approved the PR
and removed
needs CR (code review)
labels
Jul 6, 2021
ctrlaltdavid
added
needs CR (code review)
and removed
CR approved
At least one code reviewer has approved the PR
labels
Jul 7, 2021
digisomni
approved these changes
Jul 7, 2021
digisomni
added
CR approved
At least one code reviewer has approved the PR
QA approved
Has been tested successfully
and removed
needs CR (code review)
needs QA (testing)
labels
Jul 7, 2021
digisomni
changed the title
First exchange of Vircadia protocol packets with the domain server
First exchange of Vircadia protocol packets with the Domain server.
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CR approved
At least one code reviewer has approved the PR
enhancement
New feature or request
QA approved
Has been tested successfully
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR in conjunction with Vircadia PR vircadia/vircadia-native-core#1259 implements the first exchange of Vircadia protocol packets with the domain server:
DomainConnectRequest
to the domain server.DomainList
packet.This exchange is tested in Nodeslist.integration.test.js.
PR development status:
Merge sequence: This PR can be merged when ready.