Fix for _meshStates.empty() assertion. #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the comment in the code for a detailed discussion of the issue. This is a workaround, but it should be a safe one.
|
The following links are available:
build (macOS-10.15, client) build (macOS-10.15, full) build (windows-latest, full) build (self-hosted_debian-11_aarch64, full)
|
HifiExperiments
approved these changes
Nov 22, 2021
digisomni
added
bugfix
CR Approved
digisomni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comment in the code for a detailed discussion of the issue. This is
a workaround, but it should be a safe one.
Testing:
It is not known what causes the issue to happen, but it may be related to avatars. It seems to mostly happen at login, or when teleporting into a different region. It seems to happen more often with more avatars in the region.
Look for a warning:
_meshStates has N items when it should have none. Model with URL...in the logs. So far in my testing I've not managed to trigger it, so if it happens during testing please paste the output in a comment. The intention is to make the warning useful enough to locate whatever is having a problem, but I'm not yet sure if the logged information is going to be helpful and/or accurate.Closes #958