fix(v6): fix maximum call stack error in ModuleRunner.isCurcularImport
#17740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patak-dev
reviewed
Jul 23, 2024
| @@ -162,8 +162,16 @@ export class ModuleRunner { | |||
| return false | |||
| } | |||
|
|
|||
| private isCurcularImport(importers: Set<string>, moduleId: string) { | |||
| private isCurcularImport( | |||
There was a problem hiding this comment.
@hi-ogawa would you also update the name to be isCircularImport ?
There was a problem hiding this comment.
Oh, didn't notice. There's one more above isCurcularModule. I fixed that too.
|
Apart from taking the opportunity to do the rename, this looks good to me. cc @sheremet-va so you're aware. @hi-ogawa I think you can merge it directly after you update the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing v6 https://pkg.pr.new/vite@4e81092 in hi-ogawa/vite-plugins#297, I'm seeing
ModuleRunner.isCurcularImportmaximum call stack error when dynamic importing a server action.I added a test case and verified the fix. (I also patched locally on my project and verified it's fixed).