fix(v6): fix maximum call stack error in ModuleRunner.isCurcularImport

packages/vite/src/module-runner/runner.ts

@@ -162,8 +162,16 @@ export class ModuleRunner {
     return false
   }
 
-  private isCurcularImport(importers: Set<string>, moduleId: string) {
+  private isCurcularImport(
+    importers: Set<string>,
+    moduleId: string,
+    visited = new Set<string>(),
+  ) {
     for (const importer of importers) {
+      if (visited.has(importer)) {
+        continue
+      }
+      visited.add(importer)
       if (importer === moduleId) {
         return true
       }
@@ -172,7 +180,7 @@ export class ModuleRunner {
       ) as Required<ModuleCache>
       if (
         mod.importers.size &&
-        this.isCurcularImport(mod.importers, moduleId)
+        this.isCurcularImport(mod.importers, moduleId, visited)
       ) {
         return true
       }

packages/vite/src/node/ssr/runtime/__tests__/fixtures/cyclic/action.js

@@ -0,0 +1 @@
+export function someAction() {}

packages/vite/src/node/ssr/runtime/__tests__/fixtures/cyclic/entry-cyclic.js

@@ -0,0 +1,3 @@
+export default async function main() {
+	await import("./entry.js");
+}

packages/vite/src/node/ssr/runtime/__tests__/fixtures/cyclic/entry.js

@@ -0,0 +1,8 @@
+export async function setupCyclic() {
+	const mod = await import("./entry-cyclic.js");
+	await mod.default();
+}
+
+export async function importAction(id) {
+	return await import(/* @vite-ignore */ id);
+}

packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts

@@ -218,4 +218,16 @@ describe('module runner initialization', async () => {
       expect(posix.join(root, './fixtures')).toBe(dirname)
     }
   })
+
+  it(`no maximum call stack error ModuleRunner.isCurcularImport`, async ({
+    runner,
+  }) => {
+    // entry.js ⇔ entry-cyclic.js
+    //   ⇓
+    // action.js
+    const mod = await runner.import('/fixtures/cyclic/entry')
+    await mod.setupCyclic()
+    const action = await mod.importAction('/fixtures/cyclic/action')
+    expect(action).toBeDefined()
+  })
 })