Merge pull request #3335 from tinyspeck/add-support-for-truncate

Add support for TRUNCATE as DDL statement

data/test/tabletserver/ddl_cases.txt

@@ -102,3 +102,17 @@
 {
   "Action": "alter", "TableName": "a", "NewTable": "a"
 }
+
+# truncate
+"truncate a"
+{
+  "PlanID": "DDL",
+  "TableName": "a"
+}
+
+# truncate
+"truncate table a"
+{
+  "PlanID": "DDL",
+  "TableName": "a"
+}

data/test/tabletserver/exec_cases.txt

@@ -1192,13 +1192,6 @@
   "TableName": ""
 }
 
-# truncate
-"truncate a"
-{
-  "PlanID": "OTHER_ADMIN",
-  "TableName": ""
-}
-
 # table not found select
 "select * from aaaa"
 "table aaaa not found in schema"

go/vt/schemamanager/tablet_executor.go

@@ -153,7 +153,7 @@ func (exec *TabletExecutor) detectBigSchemaChanges(ctx context.Context, parsedDD
 	}
 	for _, ddl := range parsedDDLs {
 		switch ddl.Action {
-		case sqlparser.DropStr, sqlparser.CreateStr:
+		case sqlparser.DropStr, sqlparser.CreateStr, sqlparser.TruncateStr:
 			continue
 		}
 		tableName := ddl.Table.Name.String()

go/vt/schemamanager/tablet_executor_test.go

@@ -127,6 +127,12 @@ func TestTabletExecutorValidate(t *testing.T) {
 		t.Fatalf("executor.Validate should fail, change a table more than 2,000,000 rows")
 	}
 
+	if err := executor.Validate(ctx, []string{
+		"TRUNCATE TABLE test_table_04",
+	}); err != nil {
+		t.Fatalf("executor.Validate should succeed, drop a table with more than 2,000,000 rows is allowed")
+	}
+
 	if err := executor.Validate(ctx, []string{
 		"DROP TABLE test_table_04",
 	}); err != nil {

go/vt/sqlparser/ast.go

@@ -554,8 +554,8 @@ func (node *Set) WalkSubtree(visit Visit) error {
 	)
 }
 
-// DDL represents a CREATE, ALTER, DROP or RENAME statement.
-// Table is set for AlterStr, DropStr, RenameStr
+// DDL represents a CREATE, ALTER, DROP, RENAME or TRUNCATE statement.
+// Table is set for AlterStr, DropStr, RenameStr, TruncateStr
 // NewName is set for AlterStr, CreateStr, RenameStr.
 type DDL struct {
 	Action        string
@@ -568,10 +568,11 @@ type DDL struct {
 
 // DDL strings.
 const (
-	CreateStr = "create"
-	AlterStr  = "alter"
-	DropStr   = "drop"
-	RenameStr = "rename"
+	CreateStr   = "create"
+	AlterStr    = "alter"
+	DropStr     = "drop"
+	RenameStr   = "rename"
+	TruncateStr = "truncate"
 )
 
 // Format formats the node.

go/vt/sqlparser/parse_test.go

@@ -826,9 +826,12 @@ var (
 	}, {
 		input:  "explain foobar",
 		output: "otherread",
+	}, {
+		input:  "truncate table foo",
+		output: "truncate table foo",
 	}, {
 		input:  "truncate foo",
-		output: "otheradmin",
+		output: "truncate table foo",
 	}, {
 		input:  "repair foo",
 		output: "otheradmin",