Add support for TRUNCATE as DDL statement #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafael
force-pushed
the
add-support-for-truncate
branch
from
27474f3
to
083454b
Compare
|
One final nit: I think it will be a good idea to add TruncateStr to this list: https://github.com/youtube/vitess/blob/master/go/vt/schemamanager/tablet_executor.go#L156. I found this by reviewing all uses of DDL.Action. |
|
LGTM |
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
…) (vitessio#3284) (vitessio#3335) Co-authored-by: Andrés Taylor <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR adds support to execute
TRUNCATEstatements as DDL statement.I'm not 100% sure these are all the changes required, but seems to work 😄
Tests
parse_test.gobut failing locally. Want to check what happens in CI.